Fix nested nodes in commits #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes issue #380
I did this originally but didn't notice we were passing the same volatile iris map to both retract-flakes and assert-flakes, so probably not safe to parallelize.
bplatz
reviewed
Feb 14, 2023
| {:keys [flakes pid sid]} (<? (assert-flakes db assert t-new iris refs)) | ||
| all-flakes (-> (empty (get-in db [:novelty :spot])) | ||
| (into (<? retract-flakes)) | ||
| (into retract-flakes) |
There was a problem hiding this comment.
I know the <? for retracts looked misplaced as it was, but it was intentional.
Its purpose was to run the fairly costly assert-flakes and retract-flakes in parallel on different threads, as opposed to serially.
This change makes it run serially.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #380
The whole fix ended up being 12b59bc. The rest of the commits are small things I or @bplatz noticed along the way.
And since I had to lookup how to run one test in isolation for this, I added a note to the README about it.