Make load work for memory conns #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Primarily for testing purposes
It was indeed too simple. http-api-gateway was sneaking mixed keyword / string contexts in w/ memory conns. So let's just always stringify instead.
|
This looks good, but it looks like we're missing a |
Yeah there's some test helper weirdness I'm working through. |
Fixes a bug in processor/canonize that I ran into
Much easier debugging when things go wrong
Nothing in the write-data! fn needs to be inside a go-try
Not sure why this wasn't causing more problems before now, but for whatever reason testing w/ mem conn load revealed it. Might be b/c only the tests set a default did usually.
...and implement it for CLJS too
It had more in common than not
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Primarily for testing purposes. http-api-gateway needs load for 90% of what it does, so this was blocking more categories of integration tests beyond
create.We also keep running into bugs where loaded ledgers are different from the live ones. So this needs to be more heavily tested, and it's nice not to have to use file conns for tests (for speed and cleanup).
The fundamental problem turned out to be that memory conns were loading the committed data rather than the commit metadata. So it couldn't find the default context, etc.
Closes #378