-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: S3 connection method #464
Conversation
28cd889
to
c932d19
Compare
Converted to draft b/c I remembered there's one thing I still need to finish in here. Will ping when it's ready for full review. |
Instead of just taking the first ledger that loads successfully, give a target t to aim for and keep loading until we get one that is at that t value or higher.
The last commit (971dab8) is unrelated and I'm happy to split it out into its own PR if desired. But I ran into a common test failure here in one of our |
OK @fluree/core this is ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🪣
If this is after a |
Just to make sure I'm understanding things correctly: This is a (deref'd) |
That's OK then... as the name service is intentionally async. We discussed creating an option for name services that could allow ones that can more easily support it to be synchronous and block... but e.g. IPNS as a name service really needs to be async. However, the return from I'd suggest any tests with this sort of dependency opt to not use the name service unless there is something specific about the name service itself they are testing. |
Closes #450
Commit 7efcd2f is the heart of this PR.
No tests yet b/c testing S3 is a little tricky. If folks feel strongly there should be some before merging I can figure out a good way to test this locally w/o actually connecting to S3.
It works in my REPL, though! ;)