return @type instead of rdf:type #553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also updated dev namespaces, source code comments, and function docstrings.
dpetran
force-pushed
the
task/return-type
branch
from
ed5137c
to
58acde3
Compare
bplatz
reviewed
Aug 3, 2023
| @@ -68,7 +68,7 @@ | |||
|
|
|||
| @(fluree/query (fluree/db ledger) | |||
| {:select {'?s [:* {:schema/isBasedOn [:*]}]} | |||
| :where [['?s :rdf/type :schema/Movie]]}) | |||
| :where [['?s :type :schema/Movie]]}) | |||
There was a problem hiding this comment.
rdf:type or @type should work the same for a query - so these shouldn't need changing, but it shouldn't hurt to to change them either.
It is in the responses, when doing a graph crawl specifically, that we should default to returning @type instead of defaulting to rdf:type.
SPARQL will parse near directly into FlureeQL, and @type doesn't exist in SPARQL... so we don't want to loose rdf:type. SPARQL does not support a graph crawl response, which is where we are in unique Fluree land... and that is why it makes sense to change the default behavior there.
There was a problem hiding this comment.
Good point, I've added an explicit test that shows the following:
- you cannot transact with an
rdf:typepredicate - you can query with an
rdf:typepredicate and it behaves the same as using@type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #551
Uses the json-ld
@typekeyword instead of the rdfhttp://www.w3.org/1999/02/22-rdf-syntax-ns#typeIRI.Also fixes #537 by throwing an error during insert if it comes across the
rdf:typeIRI.