Replace @id w/ f:ledger in transactions #578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...for identifying the ledger. This is more semantically correct and fixes an issue with these not necessarily being IRIs which broke credential verification. Also adds context-type to connection protocol and looks it up from there in transact instead of making it an opt passed separately and redundantly.
mpoffald
reviewed
Sep 20, 2023
src/fluree/db/json_ld/api.cljc
Outdated
| Returns the new db. | ||
|
|
||
| Note: Loading the ledger results in a new ledger object, so references to existing | ||
| ledger objects will be rendered stale. To obtain a ledger with the new changes, | ||
| call `load` on the ledger alias." | ||
| [conn json-ld opts] | ||
| [conn json-ld] |
There was a problem hiding this comment.
Looks like opts is also used by h-a-g to pass in the :did: https://github.com/fluree/http-api-gateway/blob/main/src/fluree/http_api/handlers/ledger.clj#L81-L85, is that going to be an issue?
There was a problem hiding this comment.
Ah, thanks. I just searched this codebase. I'll add that back in.
There was a problem hiding this comment.
It'd be nice if someday we enumerated what the possible opts are for our top-level api fns 😄
It's used by HTTP API code
|
@mpoffald Sorry I added one more commit to get the h-a-g test suite passing (and I think it's more correct overall regardless). Mind taking a quick extra look at that? |
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...for identifying the ledger. This is more semantically correct and fixes an issue with these not necessarily being IRIs which broke credential verification.
Also adds context-type to connection protocol and looks it up from there in transact instead of making it an opt passed separately and redundantly.
Upcoming server & http-api-gateway PRs will adapt them to this change.
Part of https://github.com/fluree/core/issues/32