Feature: Use new db context handling #43
Conversation
This changed recently in db
| (let [first-txn (if (map? txn) | ||
| txn | ||
| (first txn))] | ||
| (cond-> {} | ||
| (-> first-txn keys first keyword?) (assoc :context-type :keyword) | ||
| (-> first-txn keys first string?) (assoc :context-type :string) | ||
| context (assoc :context context)))) | ||
| defaultContext (assoc :defaultContext defaultContext)))) |
There was a problem hiding this comment.
I think this causes us to ignore context on the /transact endpoint too, since this fn is called for both. Perhaps the support for defaultContext here should be strictly additive?
There was a problem hiding this comment.
🤔 wait now that I look closer, maybe that's not really a thing. I may be mixed up about the various places context can be supplied and how they should work
There was a problem hiding this comment.
Yeah, and/or I might be mixed up too / instead. Let me make sure there is test coverage of that real quick.
There was a problem hiding this comment.
Actually, looking over the current fluree.db.json-ld.api/stage code in db, I don't think you can send a context in the opts of a transaction. Just a context-type. The context would go inside the transaction's JSON-LD data, I believe (i.e. in the map under the :txn key).
There was a problem hiding this comment.
yeah, that sounds right. False alarm! 😅
fluree/db#437 introduces a new
:defaultContextkey in the create API that doesn't merge with conn default contexts unless you explicitly request that via a["" {...}]structure.This updates http-api-gateway to work with that. All of the tests now pass in this branch pointed at the
fix/contextbranch of db (plus one other small change in the history query test;:latest=>"latest").