Allow context to be cleared by setting it to nil #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swapped the order of the test clauses so the failure reports make more sense. Also some whitespace cleanup. Also changed the signature of `parse-map` to match all of the other "parse-" type functions, accepting the "externals" arg as the second arg instead of first. Also fixed up some cases where weren't passing on the base context, and gave it a clearer name.
If context is `nil`, `context/parse` will return an empty context. During expansion we need to be a little more careful that we don't pass in a nil context by accident, and instead pass in an empty context for a no-op, which was the old `nil` context behavior.
Make sure to use the expected actual form for the tests, add some tests to show behavior of "identity" operations.
dpetran
force-pushed
the
feature/clear-context
branch
from
b0d972c
to
010ea42
Compare
|
This is ready for review again. No changes were necessary, just rebased on main. |
This was referenced Apr 6, 2023
zonotope
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses/enables a solution for fluree/db#395
If a context is set to nil,
compactshould return fully expanded json-ld.