Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for globe projection in Mapbox GL for web and update map … #1424

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kellygalliani
Copy link

…call versions to v2.12

@felix-ht
Copy link
Collaborator

you should be able to set mapbox://styles/mapbox/globe-v9 without the need to expliclity set a projection? Seems somewhat unexpected that it switches styles. This would in turn also overwrite any style set by the user.

But if you want to can certainly update the mapbox js lib version.

@kellygalliani
Copy link
Author

kellygalliani commented Jul 12, 2024

  • Removed the setMapProjection method and all related references.

Thank you for reviewing and providing feedback.

@kellygalliani
Copy link
Author

Do you want me to create a new pull request instead of merging this last commit?

@kellygalliani
Copy link
Author

kellygalliani commented Aug 11, 2024

you should be able to set mapbox://styles/mapbox/globe-v9 without the need to expliclity set a projection? Seems somewhat unexpected that it switches styles. This would in turn also overwrite any style set by the user.

But if you want to can certainly update the mapbox js lib version.

Removed the setMapProjection method and all related references.
Thank you for reviewing and providing feedback.

Do you want me to create a new pull request instead of merging this last commit?

I realy need this update..please say what is required for you to acept my commit. Thanks!

Copy link

stale bot commented Oct 12, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants