Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Android Mapbox plugins and gradle #283

Merged
merged 2 commits into from
May 31, 2020
Merged

Update Android Mapbox plugins and gradle #283

merged 2 commits into from
May 31, 2020

Conversation

m0nac0
Copy link
Collaborator

@m0nac0 m0nac0 commented May 25, 2020

I upgraded the Mapbox sdk and the two Mapbox plugins we are using to the latest version, as well as gradle, because the older gradle version didn't play nicely with the new Mapbox plugins.
This should fix #263 and hopefully also #248
Big thanks to @AAverin for keeping track of the fix upstream.

@m0nac0
Copy link
Collaborator Author

m0nac0 commented May 25, 2020

I changed the gradle version to 3.5.0, which is still an upgrade from what we had before this PR and enough to make it compile. Gradle 3.6.1 causes an issue with the CI because it requires an Android NDK version that is currently not preinstalled on the Github Action runners.
The alternative would have been to install the right version of the NDK on each run of the CI, but this would have added approx. 1.5 minutes to the build time, so I decided to stick with this solution for now.

@m0nac0 m0nac0 changed the title Update mapbox plugins and gradle Update Android Mapbox plugins and gradle May 25, 2020
@AAverin
Copy link
Contributor

AAverin commented May 28, 2020

@m0nac0 any way I can help to make it a release? I a bit blocked by the map crashing

@m0nac0
Copy link
Collaborator Author

m0nac0 commented May 28, 2020

@AAverin I'm sorry for the delay, but merging will be blocked until one of the other contributors approves the PR. If you depend on this, I'd recommend you to use a git dependency with the ref tag in pubspec.yaml and depend on the m0-update-sdk branch I used for this PR. There's an explanation of this at https://dart.dev/tools/pub/dependencies#git-packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mapbox Android 8.5.0 unstable
3 participants