Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix for rescale issues on web #896

Merged
merged 1 commit into from
Feb 7, 2022

Conversation

felix-ht
Copy link
Collaborator

@felix-ht felix-ht commented Feb 4, 2022

added a hotfix for #795 as #889 did not fix the issue. This still feels quite sloppy - however it seems like the best option we have for now.

I also deleted some unused code - and with it an api that the controller should have never exposed in the first place.

@felix-ht felix-ht requested a review from Chaoba February 4, 2022 16:26
@treehousetim
Copy link

I've been waiting for a fix for the resize since December. This looks promising - any idea when a new release will be cut and available via normal channels?

Thanks for your work on this!

@felix-ht felix-ht merged commit 4163335 into flutter-mapbox-gl:master Feb 7, 2022
@felix-ht
Copy link
Collaborator Author

felix-ht commented Feb 7, 2022

@treehousetim hard to say. You can fork this repo tho and directly use that one to get all the latest changes right away. So you still have some control over when the version you put into your release.

@lukemadera
Copy link

Thanks @felix-ht I spoke too soon and was still seeing some issues too. Excited to try this new fix when it is released!

@felix-ht
Copy link
Collaborator Author

i did some more testing and there still are some issues. These mostly seem happen if a existing map is reinserted into the widget tree. (Going to another page and returning to the map with a pop)

In this case the hotfix does not work, as the style is not reloaded.

@lukemadera
Copy link

Yeah, that checks out with what I'm seeing. Can we add a manual hook into the resize function for now at least to give us control to force resize it? May not be the best solution, but we need a fix ASAP and a timeout to check and resize is far better than a mini map that's not usable.

@felix-ht
Copy link
Collaborator Author

felix-ht commented Feb 11, 2022

@lukemadera a quick hack would be to just have two styles that are essentially the same but have different mapbox URIs
With this you could force a reload - but certainly quite hacky

@felix-ht
Copy link
Collaborator Author

Note that this is of high priority for me as well an I will try to have a full fix soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants