Revert shell/platform/common/BUILD.gn #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Required for x64 builds Signed-off-by: MuHong Byun <[email protected]>
|
The difference is quite obvious. Compare the sizes of the embedders (libflutter_tizen*.so) and you will see the difference. |
Signed-off-by: MuHong Byun <[email protected]>
|
@swift-kim Oh, In that case, How about now? |
swift-kim
approved these changes
Jun 17, 2021
bbrto21
reviewed
Jun 17, 2021
Co-authored-by: Boram Bae <[email protected]>
swift-kim
pushed a commit
that referenced
this pull request
Sep 27, 2021
* Revert shell/platform/common/BUILD.gn * Required for x64 builds Signed-off-by: MuHong Byun <[email protected]> * Changed not to be included in Tizen Signed-off-by: MuHong Byun <[email protected]> * Apply review's comment Co-authored-by: Boram Bae <[email protected]> Co-authored-by: Boram Bae <[email protected]>
swift-kim
pushed a commit
that referenced
this pull request
Nov 14, 2021
* Revert shell/platform/common/BUILD.gn * Required for x64 builds Signed-off-by: MuHong Byun <[email protected]> * Changed not to be included in Tizen Signed-off-by: MuHong Byun <[email protected]> * Apply review's comment Co-authored-by: Boram Bae <[email protected]> Co-authored-by: Boram Bae <[email protected]>
swift-kim
pushed a commit
that referenced
this pull request
Dec 9, 2021
* Revert shell/platform/common/BUILD.gn * Required for x64 builds Signed-off-by: MuHong Byun <[email protected]> * Changed not to be included in Tizen Signed-off-by: MuHong Byun <[email protected]> * Apply review's comment Co-authored-by: Boram Bae <[email protected]> Co-authored-by: Boram Bae <[email protected]>
swift-kim
pushed a commit
that referenced
this pull request
Dec 17, 2021
* Revert shell/platform/common/BUILD.gn * Required for x64 builds * Changed not to be included in Tizen Signed-off-by: MuHong Byun <[email protected]> Co-authored-by: Boram Bae <[email protected]>
swift-kim
pushed a commit
that referenced
this pull request
Feb 7, 2022
* Revert shell/platform/common/BUILD.gn * Required for x64 builds * Changed not to be included in Tizen Signed-off-by: MuHong Byun <[email protected]> Co-authored-by: Boram Bae <[email protected]>
swift-kim
pushed a commit
that referenced
this pull request
Feb 11, 2022
* Revert shell/platform/common/BUILD.gn * Required for x64 builds * Changed not to be included in Tizen Signed-off-by: MuHong Byun <[email protected]> Co-authored-by: Boram Bae <[email protected]>
swift-kim
pushed a commit
that referenced
this pull request
May 12, 2022
* Revert shell/platform/common/BUILD.gn * Required for x64 builds * Changed not to be included in Tizen Signed-off-by: MuHong Byun <[email protected]> Co-authored-by: Boram Bae <[email protected]>
swift-kim
pushed a commit
that referenced
this pull request
Aug 5, 2022
* Revert shell/platform/common/BUILD.gn * Required for x64 builds * Changed not to be included in Tizen Signed-off-by: MuHong Byun <[email protected]> Co-authored-by: Boram Bae <[email protected]>
swift-kim
pushed a commit
that referenced
this pull request
Sep 1, 2022
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.1.6 to 2.1.7. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@28eead2...0182a2c) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
swift-kim
pushed a commit
that referenced
this pull request
Sep 1, 2022
* Revert shell/platform/common/BUILD.gn * Required for x64 builds * Changed not to be included in Tizen Signed-off-by: MuHong Byun <[email protected]> Co-authored-by: Boram Bae <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For running embedder's unit test, I need x64 build.
(I am modifying the embedder API for the
FlutterEngineGroupAPI, and I want to add a unit test.)Unfortunately, modification of BUILD.gn are preventing that task.
This change came from here, I couldn't find a reason. previous_work
Does anyone know the history?
Can I reverse this?