Refactor platform view channel #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Boram Bae <[email protected]>
Signed-off-by: Boram Bae <[email protected]>
bwikbs
reviewed
Jun 18, 2021
| flutter::EncodableValue value = values[flutter::EncodableValue(key)]; | ||
| if (std::holds_alternative<flutter::EncodableList>(value)) { | ||
| return std::get<flutter::EncodableList>(value); | ||
| template <typename T> |
There was a problem hiding this comment.
Oh! It looks very clear! Thanks! 👍
Signed-off-by: Boram Bae <[email protected]>
bwikbs
approved these changes
Jun 18, 2021
swift-kim
reviewed
Jun 18, 2021
swift-kim
approved these changes
Jun 18, 2021
swift-kim
pushed a commit
that referenced
this pull request
Sep 27, 2021
* Use template to extract value from argmuments map Signed-off-by: Boram Bae <[email protected]> * Cleanup platform_view_channel Signed-off-by: Boram Bae <[email protected]> * Fix a typo Signed-off-by: Boram Bae <[email protected]>
swift-kim
pushed a commit
that referenced
this pull request
Nov 14, 2021
* Use template to extract value from argmuments map Signed-off-by: Boram Bae <[email protected]> * Cleanup platform_view_channel Signed-off-by: Boram Bae <[email protected]> * Fix a typo Signed-off-by: Boram Bae <[email protected]>
swift-kim
pushed a commit
that referenced
this pull request
Dec 9, 2021
* Use template to extract value from argmuments map Signed-off-by: Boram Bae <[email protected]> * Cleanup platform_view_channel Signed-off-by: Boram Bae <[email protected]> * Fix a typo Signed-off-by: Boram Bae <[email protected]>
swift-kim
pushed a commit
that referenced
this pull request
Dec 17, 2021
* Use template to extract value from argmuments map * Cleanup platform_view_channel Signed-off-by: Boram Bae <[email protected]>
swift-kim
pushed a commit
that referenced
this pull request
Feb 7, 2022
* Use template to extract value from argmuments map * Cleanup platform_view_channel Signed-off-by: Boram Bae <[email protected]>
swift-kim
pushed a commit
that referenced
this pull request
Feb 11, 2022
* Use template to extract value from argmuments map * Cleanup platform_view_channel Signed-off-by: Boram Bae <[email protected]>
swift-kim
pushed a commit
that referenced
this pull request
May 12, 2022
* Use template to extract value from argmuments map * Cleanup platform_view_channel Signed-off-by: Boram Bae <[email protected]>
swift-kim
pushed a commit
that referenced
this pull request
Aug 5, 2022
* Use template to extract value from argmuments map * Cleanup platform_view_channel Signed-off-by: Boram Bae <[email protected]>
swift-kim
pushed a commit
that referenced
this pull request
Sep 1, 2022
swift-kim
pushed a commit
that referenced
this pull request
Sep 1, 2022
* Use template to extract value from argmuments map * Cleanup platform_view_channel Signed-off-by: Boram Bae <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes: