forked from flutter/engine
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for incoming application control #154
Merged
swift-kim
merged 18 commits into
flutter-tizen:flutter-2.2.1-tizen
from
rwalczyna:app_control
Aug 4, 2021
Merged
Add support for incoming application control #154
swift-kim
merged 18 commits into
flutter-tizen:flutter-2.2.1-tizen
from
rwalczyna:app_control
Aug 4, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rafal Walczyna <[email protected]>
Signed-off-by: Rafal Walczyna <[email protected]>
Signed-off-by: Rafal Walczyna <[email protected]>
Signed-off-by: Rafal Walczyna <[email protected]>
Signed-off-by: Rafal Walczyna <[email protected]>
Signed-off-by: Rafal Walczyna <[email protected]>
Signed-off-by: Rafal Walczyna <[email protected]>
Signed-off-by: Rafal Walczyna <[email protected]>
Signed-off-by: Rafal Walczyna <[email protected]>
…ouble launch Signed-off-by: Rafal Walczyna <[email protected]>
Signed-off-by: Rafal Walczyna <[email protected]>
Signed-off-by: Rafal Walczyna <[email protected]>
swift-kim
reviewed
Jul 26, 2021
swift-kim
reviewed
Jul 26, 2021
Signed-off-by: Rafal Walczyna <[email protected]>
Signed-off-by: Rafal Walczyna <[email protected]>
Signed-off-by: Rafal Walczyna <[email protected]>
swift-kim
reviewed
Jul 27, 2021
* renamings * missing empty lines or dots * changed way of returning extra data * masking of app_control in flutter_tizen_engine.* and flutter_tizen.* files
swift-kim
reviewed
Jul 29, 2021
swift-kim
approved these changes
Aug 2, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I'll organize #includes later. Otherwise looks good to me.
bbrto21
reviewed
Aug 2, 2021
bbrto21
approved these changes
Aug 4, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
swift-kim
pushed a commit
that referenced
this pull request
Sep 27, 2021
* [AppControl] Add support for reading operation from app_control Signed-off-by: Rafal Walczyna <[email protected]> * [AppControl] Add EventChannel and queue for app controls Signed-off-by: Rafal Walczyna <[email protected]> * [AppControl] Add basic operations for AppControl Signed-off-by: Rafal Walczyna <[email protected]> * [AppControl] Refactor extra data to use EncodableValue Signed-off-by: Rafal Walczyna <[email protected]> * [AppControl] Refactor HandleMethodCall Signed-off-by: Rafal Walczyna <[email protected]> * [AppControl] Refactor Event, Send and Terminate logic Signed-off-by: Rafal Walczyna <[email protected]> * [AppControl] Add support for extra data and dispose Signed-off-by: Rafal Walczyna <[email protected]> * [AppControl] Add support for reply Signed-off-by: Rafal Walczyna <[email protected]> * [AppControl] Add support for launch mode and organize logs Signed-off-by: Rafal Walczyna <[email protected]> * [AppControl] Fix bugs with not saving app control on reply and with double launch Signed-off-by: Rafal Walczyna <[email protected]> * [AppControl] Update logs and comments Signed-off-by: Rafal Walczyna <[email protected]> * Run code formatter Signed-off-by: Rafal Walczyna <[email protected]> * [AppControl] Fixes after code review Signed-off-by: Rafal Walczyna <[email protected]> * [AppControl] Add missing files Signed-off-by: Rafal Walczyna <[email protected]> * [AppControl] Changel enums to lowerCase Signed-off-by: Rafal Walczyna <[email protected]> * [appcontrol] Fixes after review * renamings * missing empty lines or dots * changed way of returning extra data * masking of app_control in flutter_tizen_engine.* and flutter_tizen.* files * [appcontrol] Few more fixes for review * [appcontrol] Removed unnecessary code and initialized poiters with nullptr Co-authored-by: Piotr Kosko/Tizen API (PLT) /SRPOL/Engineer/Samsung Electronics <[email protected]>
swift-kim
pushed a commit
that referenced
this pull request
Nov 14, 2021
* [AppControl] Add support for reading operation from app_control Signed-off-by: Rafal Walczyna <[email protected]> * [AppControl] Add EventChannel and queue for app controls Signed-off-by: Rafal Walczyna <[email protected]> * [AppControl] Add basic operations for AppControl Signed-off-by: Rafal Walczyna <[email protected]> * [AppControl] Refactor extra data to use EncodableValue Signed-off-by: Rafal Walczyna <[email protected]> * [AppControl] Refactor HandleMethodCall Signed-off-by: Rafal Walczyna <[email protected]> * [AppControl] Refactor Event, Send and Terminate logic Signed-off-by: Rafal Walczyna <[email protected]> * [AppControl] Add support for extra data and dispose Signed-off-by: Rafal Walczyna <[email protected]> * [AppControl] Add support for reply Signed-off-by: Rafal Walczyna <[email protected]> * [AppControl] Add support for launch mode and organize logs Signed-off-by: Rafal Walczyna <[email protected]> * [AppControl] Fix bugs with not saving app control on reply and with double launch Signed-off-by: Rafal Walczyna <[email protected]> * [AppControl] Update logs and comments Signed-off-by: Rafal Walczyna <[email protected]> * Run code formatter Signed-off-by: Rafal Walczyna <[email protected]> * [AppControl] Fixes after code review Signed-off-by: Rafal Walczyna <[email protected]> * [AppControl] Add missing files Signed-off-by: Rafal Walczyna <[email protected]> * [AppControl] Changel enums to lowerCase Signed-off-by: Rafal Walczyna <[email protected]> * [appcontrol] Fixes after review * renamings * missing empty lines or dots * changed way of returning extra data * masking of app_control in flutter_tizen_engine.* and flutter_tizen.* files * [appcontrol] Few more fixes for review * [appcontrol] Removed unnecessary code and initialized poiters with nullptr Co-authored-by: Piotr Kosko/Tizen API (PLT) /SRPOL/Engineer/Samsung Electronics <[email protected]>
swift-kim
pushed a commit
that referenced
this pull request
Dec 9, 2021
* [AppControl] Add support for reading operation from app_control Signed-off-by: Rafal Walczyna <[email protected]> * [AppControl] Add EventChannel and queue for app controls Signed-off-by: Rafal Walczyna <[email protected]> * [AppControl] Add basic operations for AppControl Signed-off-by: Rafal Walczyna <[email protected]> * [AppControl] Refactor extra data to use EncodableValue Signed-off-by: Rafal Walczyna <[email protected]> * [AppControl] Refactor HandleMethodCall Signed-off-by: Rafal Walczyna <[email protected]> * [AppControl] Refactor Event, Send and Terminate logic Signed-off-by: Rafal Walczyna <[email protected]> * [AppControl] Add support for extra data and dispose Signed-off-by: Rafal Walczyna <[email protected]> * [AppControl] Add support for reply Signed-off-by: Rafal Walczyna <[email protected]> * [AppControl] Add support for launch mode and organize logs Signed-off-by: Rafal Walczyna <[email protected]> * [AppControl] Fix bugs with not saving app control on reply and with double launch Signed-off-by: Rafal Walczyna <[email protected]> * [AppControl] Update logs and comments Signed-off-by: Rafal Walczyna <[email protected]> * Run code formatter Signed-off-by: Rafal Walczyna <[email protected]> * [AppControl] Fixes after code review Signed-off-by: Rafal Walczyna <[email protected]> * [AppControl] Add missing files Signed-off-by: Rafal Walczyna <[email protected]> * [AppControl] Changel enums to lowerCase Signed-off-by: Rafal Walczyna <[email protected]> * [appcontrol] Fixes after review * renamings * missing empty lines or dots * changed way of returning extra data * masking of app_control in flutter_tizen_engine.* and flutter_tizen.* files * [appcontrol] Few more fixes for review * [appcontrol] Removed unnecessary code and initialized poiters with nullptr Co-authored-by: Piotr Kosko/Tizen API (PLT) /SRPOL/Engineer/Samsung Electronics <[email protected]>
swift-kim
pushed a commit
that referenced
this pull request
Dec 17, 2021
Signed-off-by: Rafal Walczyna <[email protected]> Co-authored-by: Piotr Kosko/Tizen API (PLT) /SRPOL/Engineer/Samsung Electronics <[email protected]>
swift-kim
pushed a commit
that referenced
this pull request
Feb 7, 2022
Signed-off-by: Rafal Walczyna <[email protected]> Co-authored-by: Piotr Kosko/Tizen API (PLT) /SRPOL/Engineer/Samsung Electronics <[email protected]>
swift-kim
pushed a commit
that referenced
this pull request
Feb 11, 2022
Signed-off-by: Rafal Walczyna <[email protected]> Co-authored-by: Piotr Kosko/Tizen API (PLT) /SRPOL/Engineer/Samsung Electronics <[email protected]>
swift-kim
pushed a commit
that referenced
this pull request
May 12, 2022
Signed-off-by: Rafal Walczyna <[email protected]> Co-authored-by: Piotr Kosko/Tizen API (PLT) /SRPOL/Engineer/Samsung Electronics <[email protected]>
swift-kim
pushed a commit
that referenced
this pull request
Aug 5, 2022
Signed-off-by: Rafal Walczyna <[email protected]> Co-authored-by: Piotr Kosko/Tizen API (PLT) /SRPOL/Engineer/Samsung Electronics <[email protected]>
swift-kim
pushed a commit
that referenced
this pull request
Sep 1, 2022
swift-kim
pushed a commit
that referenced
this pull request
Sep 1, 2022
Signed-off-by: Rafal Walczyna <[email protected]> Co-authored-by: Piotr Kosko/Tizen API (PLT) /SRPOL/Engineer/Samsung Electronics <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a part of adding support for incoming application control.
Corresponding flutter-tizen change: flutter-tizen/flutter-tizen#174
Dart part of the plugin is currently in internal f-project repository.