Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for incoming application control #154

Merged
merged 18 commits into from
Aug 4, 2021

Conversation

rwalczyna
Copy link

This is a part of adding support for incoming application control.
Corresponding flutter-tizen change: flutter-tizen/flutter-tizen#174

Dart part of the plugin is currently in internal f-project repository.

Signed-off-by: Rafal Walczyna <[email protected]>
shell/platform/tizen/channels/app_control_channel.cc Outdated Show resolved Hide resolved
shell/platform/tizen/channels/app_control_channel.h Outdated Show resolved Hide resolved
shell/platform/tizen/channels/app_control_channel.cc Outdated Show resolved Hide resolved
shell/platform/tizen/channels/app_control_channel.cc Outdated Show resolved Hide resolved
shell/platform/tizen/channels/app_control_channel.cc Outdated Show resolved Hide resolved
shell/platform/tizen/channels/app_control_channel.cc Outdated Show resolved Hide resolved
shell/platform/tizen/channels/app_control_channel.cc Outdated Show resolved Hide resolved
shell/platform/tizen/channels/app_control_channel.cc Outdated Show resolved Hide resolved
shell/platform/tizen/channels/app_control_channel.cc Outdated Show resolved Hide resolved
shell/platform/tizen/public/flutter_tizen.h Outdated Show resolved Hide resolved
shell/platform/tizen/channels/app_control.cc Outdated Show resolved Hide resolved
shell/platform/tizen/channels/app_control.cc Outdated Show resolved Hide resolved
shell/platform/tizen/channels/app_control.h Outdated Show resolved Hide resolved
shell/platform/tizen/channels/app_control.h Outdated Show resolved Hide resolved
shell/platform/tizen/channels/app_control.h Outdated Show resolved Hide resolved
shell/platform/tizen/channels/app_control_channel.cc Outdated Show resolved Hide resolved
shell/platform/tizen/public/flutter_tizen.h Outdated Show resolved Hide resolved
shell/platform/tizen/flutter_tizen_engine.h Show resolved Hide resolved
shell/platform/tizen/BUILD.gn Outdated Show resolved Hide resolved
* renamings
* missing empty lines or dots
* changed way of returning extra data
* masking of app_control in flutter_tizen_engine.* and flutter_tizen.*
files
shell/platform/tizen/channels/app_control.cc Outdated Show resolved Hide resolved
shell/platform/tizen/flutter_tizen.cc Outdated Show resolved Hide resolved
shell/platform/tizen/flutter_tizen_engine.h Outdated Show resolved Hide resolved
Copy link
Member

@swift-kim swift-kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I'll organize #includes later. Otherwise looks good to me.

shell/platform/tizen/BUILD.gn Show resolved Hide resolved
shell/platform/tizen/channels/app_control.cc Outdated Show resolved Hide resolved
shell/platform/tizen/channels/app_control.cc Show resolved Hide resolved
shell/platform/tizen/channels/app_control_channel.cc Outdated Show resolved Hide resolved
shell/platform/tizen/channels/app_control.cc Outdated Show resolved Hide resolved
shell/platform/tizen/channels/app_control.h Outdated Show resolved Hide resolved
shell/platform/tizen/channels/app_control.h Outdated Show resolved Hide resolved
Copy link

@bbrto21 bbrto21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@swift-kim swift-kim merged commit 649809d into flutter-tizen:flutter-2.2.1-tizen Aug 4, 2021
swift-kim pushed a commit that referenced this pull request Sep 27, 2021
* [AppControl] Add support for reading operation from app_control

Signed-off-by: Rafal Walczyna <[email protected]>

* [AppControl] Add EventChannel and queue for app controls

Signed-off-by: Rafal Walczyna <[email protected]>

* [AppControl] Add basic operations for AppControl

Signed-off-by: Rafal Walczyna <[email protected]>

* [AppControl] Refactor extra data to use EncodableValue

Signed-off-by: Rafal Walczyna <[email protected]>

* [AppControl] Refactor HandleMethodCall

Signed-off-by: Rafal Walczyna <[email protected]>

* [AppControl] Refactor Event, Send and Terminate logic

Signed-off-by: Rafal Walczyna <[email protected]>

* [AppControl] Add support for extra data and dispose

Signed-off-by: Rafal Walczyna <[email protected]>

* [AppControl] Add support for reply

Signed-off-by: Rafal Walczyna <[email protected]>

* [AppControl] Add support for launch mode and organize logs

Signed-off-by: Rafal Walczyna <[email protected]>

* [AppControl] Fix bugs with not saving app control on reply and with double launch

Signed-off-by: Rafal Walczyna <[email protected]>

* [AppControl] Update logs and comments

Signed-off-by: Rafal Walczyna <[email protected]>

* Run code formatter

Signed-off-by: Rafal Walczyna <[email protected]>

* [AppControl] Fixes after code review

Signed-off-by: Rafal Walczyna <[email protected]>

* [AppControl] Add missing files

Signed-off-by: Rafal Walczyna <[email protected]>

* [AppControl] Changel enums to lowerCase

Signed-off-by: Rafal Walczyna <[email protected]>

* [appcontrol] Fixes after review

* renamings
* missing empty lines or dots
* changed way of returning extra data
* masking of app_control in flutter_tizen_engine.* and flutter_tizen.*
files

* [appcontrol] Few more fixes for review

* [appcontrol] Removed unnecessary code and initialized poiters with nullptr

Co-authored-by: Piotr Kosko/Tizen API (PLT) /SRPOL/Engineer/Samsung Electronics <[email protected]>
swift-kim pushed a commit that referenced this pull request Nov 14, 2021
* [AppControl] Add support for reading operation from app_control

Signed-off-by: Rafal Walczyna <[email protected]>

* [AppControl] Add EventChannel and queue for app controls

Signed-off-by: Rafal Walczyna <[email protected]>

* [AppControl] Add basic operations for AppControl

Signed-off-by: Rafal Walczyna <[email protected]>

* [AppControl] Refactor extra data to use EncodableValue

Signed-off-by: Rafal Walczyna <[email protected]>

* [AppControl] Refactor HandleMethodCall

Signed-off-by: Rafal Walczyna <[email protected]>

* [AppControl] Refactor Event, Send and Terminate logic

Signed-off-by: Rafal Walczyna <[email protected]>

* [AppControl] Add support for extra data and dispose

Signed-off-by: Rafal Walczyna <[email protected]>

* [AppControl] Add support for reply

Signed-off-by: Rafal Walczyna <[email protected]>

* [AppControl] Add support for launch mode and organize logs

Signed-off-by: Rafal Walczyna <[email protected]>

* [AppControl] Fix bugs with not saving app control on reply and with double launch

Signed-off-by: Rafal Walczyna <[email protected]>

* [AppControl] Update logs and comments

Signed-off-by: Rafal Walczyna <[email protected]>

* Run code formatter

Signed-off-by: Rafal Walczyna <[email protected]>

* [AppControl] Fixes after code review

Signed-off-by: Rafal Walczyna <[email protected]>

* [AppControl] Add missing files

Signed-off-by: Rafal Walczyna <[email protected]>

* [AppControl] Changel enums to lowerCase

Signed-off-by: Rafal Walczyna <[email protected]>

* [appcontrol] Fixes after review

* renamings
* missing empty lines or dots
* changed way of returning extra data
* masking of app_control in flutter_tizen_engine.* and flutter_tizen.*
files

* [appcontrol] Few more fixes for review

* [appcontrol] Removed unnecessary code and initialized poiters with nullptr

Co-authored-by: Piotr Kosko/Tizen API (PLT) /SRPOL/Engineer/Samsung Electronics <[email protected]>
swift-kim pushed a commit that referenced this pull request Dec 9, 2021
* [AppControl] Add support for reading operation from app_control

Signed-off-by: Rafal Walczyna <[email protected]>

* [AppControl] Add EventChannel and queue for app controls

Signed-off-by: Rafal Walczyna <[email protected]>

* [AppControl] Add basic operations for AppControl

Signed-off-by: Rafal Walczyna <[email protected]>

* [AppControl] Refactor extra data to use EncodableValue

Signed-off-by: Rafal Walczyna <[email protected]>

* [AppControl] Refactor HandleMethodCall

Signed-off-by: Rafal Walczyna <[email protected]>

* [AppControl] Refactor Event, Send and Terminate logic

Signed-off-by: Rafal Walczyna <[email protected]>

* [AppControl] Add support for extra data and dispose

Signed-off-by: Rafal Walczyna <[email protected]>

* [AppControl] Add support for reply

Signed-off-by: Rafal Walczyna <[email protected]>

* [AppControl] Add support for launch mode and organize logs

Signed-off-by: Rafal Walczyna <[email protected]>

* [AppControl] Fix bugs with not saving app control on reply and with double launch

Signed-off-by: Rafal Walczyna <[email protected]>

* [AppControl] Update logs and comments

Signed-off-by: Rafal Walczyna <[email protected]>

* Run code formatter

Signed-off-by: Rafal Walczyna <[email protected]>

* [AppControl] Fixes after code review

Signed-off-by: Rafal Walczyna <[email protected]>

* [AppControl] Add missing files

Signed-off-by: Rafal Walczyna <[email protected]>

* [AppControl] Changel enums to lowerCase

Signed-off-by: Rafal Walczyna <[email protected]>

* [appcontrol] Fixes after review

* renamings
* missing empty lines or dots
* changed way of returning extra data
* masking of app_control in flutter_tizen_engine.* and flutter_tizen.*
files

* [appcontrol] Few more fixes for review

* [appcontrol] Removed unnecessary code and initialized poiters with nullptr

Co-authored-by: Piotr Kosko/Tizen API (PLT) /SRPOL/Engineer/Samsung Electronics <[email protected]>
swift-kim pushed a commit that referenced this pull request Dec 17, 2021
Signed-off-by: Rafal Walczyna <[email protected]>

Co-authored-by: Piotr Kosko/Tizen API (PLT) /SRPOL/Engineer/Samsung Electronics <[email protected]>
swift-kim pushed a commit that referenced this pull request Feb 7, 2022
Signed-off-by: Rafal Walczyna <[email protected]>

Co-authored-by: Piotr Kosko/Tizen API (PLT) /SRPOL/Engineer/Samsung Electronics <[email protected]>
swift-kim pushed a commit that referenced this pull request Feb 11, 2022
Signed-off-by: Rafal Walczyna <[email protected]>

Co-authored-by: Piotr Kosko/Tizen API (PLT) /SRPOL/Engineer/Samsung Electronics <[email protected]>
swift-kim pushed a commit that referenced this pull request May 12, 2022
Signed-off-by: Rafal Walczyna <[email protected]>

Co-authored-by: Piotr Kosko/Tizen API (PLT) /SRPOL/Engineer/Samsung Electronics <[email protected]>
swift-kim pushed a commit that referenced this pull request Aug 5, 2022
Signed-off-by: Rafal Walczyna <[email protected]>

Co-authored-by: Piotr Kosko/Tizen API (PLT) /SRPOL/Engineer/Samsung Electronics <[email protected]>
swift-kim pushed a commit that referenced this pull request Sep 1, 2022
swift-kim pushed a commit that referenced this pull request Sep 1, 2022
Signed-off-by: Rafal Walczyna <[email protected]>

Co-authored-by: Piotr Kosko/Tizen API (PLT) /SRPOL/Engineer/Samsung Electronics <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants