[Re-land] Bump to Android API 34 #792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
reidbaker
approved these changes
Nov 8, 2023
gmackall
added
the
autosubmit
auto-submit bot
pushed a commit
to flutter/engine
that referenced
this pull request
Nov 8, 2023
~**This should not land until flutter/buildroot#790 (re)lands, and I swap the buildroot url back to the latest commit.**~ ~Reland of PR to update buildroot at flutter/buildroot#792. ~ <- landed, and changed the buildroot commit to the latest in DEPS Upgrades to android api 34 Also: 1. Upgrades to java 17 in DEPS/ci, because the linter now requires it. 2. Stops running some roboelectric tests on android apis 16-18, because Roboelectric indicated those versions were unsupported and we don't support them either. 3. Applies the four trivial new suggestions from the newer linter. 4. Updates the baseline lint to include the new non-trivial lint ([fixed in a different PR](https://github.com/flutter/engine/pull/47817/files)). 5. Changes some instances where we were hardcoding android apis as numbers (e.g. `sdk = 16') to use version codes (see the [comment below](#47609 (comment))). [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
8 tasks
auto-submit bot
added a commit
to flutter/engine
that referenced
this pull request
Nov 8, 2023
Reverts #47609 Initiated by: zanderso This change reverts the following previous change: Original Description: ~**This should not land until flutter/buildroot#790 (re)lands, and I swap the buildroot url back to the latest commit.**~ ~Reland of PR to update buildroot at flutter/buildroot#792. ~ <- landed, and changed the buildroot commit to the latest in DEPS Upgrades to android api 34 Also: 1. Upgrades to java 17 in DEPS/ci, because the linter now requires it. 2. Stops running some roboelectric tests on android apis 16-18, because Roboelectric indicated those versions were unsupported and we don't support them either. 3. Applies the four trivial new suggestions from the newer linter. 4. Updates the baseline lint to include the new non-trivial lint ([fixed in a different PR](https://github.com/flutter/engine/pull/47817/files)). 5. Changes some instances where we were hardcoding android apis as numbers (e.g. `sdk = 16') to use version codes (see the [comment below](#47609 (comment))). [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-land #790 now that flutter/engine#47609 is approved and passing checks
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.