Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add scripts to generate ruby packages. #3125

Merged
merged 22 commits into from
Oct 12, 2023
Merged

Add scripts to generate ruby packages. #3125

merged 22 commits into from
Oct 12, 2023

Conversation

godofredoc
Copy link
Contributor

@godofredoc godofredoc commented Oct 6, 2023 •
edited
Loading

This is required to automatically create ruby packages for flutter testing.

Bug: flutter/flutter#122057
Bug: flutter/flutter#125812
Bug: flutter/flutter#133096
Bug: flutter/flutter#136377

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

yusuf-goog
yusuf-goog reviewed Oct 6, 2023
View reviewed changes
cipd_packages/ruby/README Outdated Show resolved Hide resolved
AUTHORS Outdated Show resolved Hide resolved
@ricardoamador
Copy link
Contributor

This reminds me of writing rpm installer scripts.

keyonghan
keyonghan reviewed Oct 10, 2023
View reviewed changes
.ci.yaml Outdated
- cipd_packages/ruby/**
- .ci.yaml

- name: Mac arm_ruby
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should define a new platform: Mac_arm to build an arm versioned ruby.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I follow what would be the benefit of creating a new platform? the cpu dimension will achieve the same purpose.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to keep consistent with other repos. This is not a big issue for Cocoon for now, which has a limited number of targets. If we have more targets in the future, we have to update the target level cpu for each of the targets. With a platform entry, you just need to update a single place.

keyonghan
keyonghan reviewed Oct 10, 2023
View reviewed changes
.ci.yaml Outdated Show resolved Hide resolved
.ci.yaml Show resolved Hide resolved
keyonghan
keyonghan reviewed Oct 10, 2023
View reviewed changes
Copy link
Contributor

@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a run-through LED build for these logics I can take a look?

.ci.yaml Outdated
- cipd_packages/ruby/**
- .ci.yaml

- name: Mac arm_ruby
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to keep consistent with other repos. This is not a big issue for Cocoon for now, which has a limited number of targets. If we have more targets in the future, we have to update the target level cpu for each of the targets. With a platform entry, you just need to update a single place.

keyonghan
keyonghan reviewed Oct 10, 2023
View reviewed changes
Copy link
Contributor

@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add an entry to the CODEOWNERS: https://github.com/flutter/cocoon/blob/main/CODEOWNERS

AUTHORS Outdated Show resolved Hide resolved
@godofredoc
Copy link
Contributor Author

Please also add an entry to the CODEOWNERS: https://github.com/flutter/cocoon/blob/main/CODEOWNERS

Done!

@godofredoc godofredoc mentioned this pull request Oct 11, 2023
Closed
@godofredoc
Copy link
Contributor Author

Is there a run-through LED build for these logics I can take a look?

https://chromium-swarm.appspot.com/task?id=6538e31922d87810

keyonghan
keyonghan approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

christopherfujino
christopherfujino approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ship it

@godofredoc godofredoc added the autosubmit Merge PR when tree becomes green via auto submit App. label Oct 12, 2023
@auto-submit auto-submit bot merged commit da89a97 into flutter:main Oct 12, 2023
10 checks passed
@godofredoc godofredoc deleted the add_ruby branch October 12, 2023 00:42
@jmagman jmagman mentioned this pull request Oct 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yusuf-goog yusuf-goog yusuf-goog left review comments

@ricardoamador ricardoamador ricardoamador left review comments

@keyonghan keyonghan keyonghan approved these changes

@christopherfujino christopherfujino christopherfujino approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@godofredoc @ricardoamador @christopherfujino @keyonghan @yusuf-goog