Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable three lint rules which are being removed. #3991

Merged
merged 3 commits into from
Nov 1, 2024

Conversation

srawlins
Copy link
Contributor

Each of these three are going to be removed soon.

  • avoid_null_checks_in_equality_operators
  • package_api_docs
  • unsafe_html

Work towards dart-lang/linter#5063 and dart-lang/linter#5001

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

* avoid_null_checks_in_equality_operators
* package_api_docs
* unsafe_html
@srawlins srawlins requested a review from Hixie as a code owner October 28, 2024 17:39
@srawlins
Copy link
Contributor Author

A replacement for #3991, unless these should be landed one at a time 🤷

@srawlins
Copy link
Contributor Author

@yjbanov who is a good approver for cocoon? 😁

@srawlins
Copy link
Contributor Author

srawlins commented Nov 1, 2024

@jtmcdole who is a good approver for cocoon? 😄

@jtmcdole
Copy link
Contributor

jtmcdole commented Nov 1, 2024

I didn't realize this had been sitting here for a while. lgtm

@srawlins srawlins added the autosubmit Merge PR when tree becomes green via auto submit App. label Nov 1, 2024
@auto-submit auto-submit bot merged commit ded610e into flutter:main Nov 1, 2024
3 checks passed
@srawlins srawlins deleted the avoid_null_checks branch November 4, 2024 16:07
srawlins added a commit to flutter/tests that referenced this pull request Nov 6, 2024
auto-submit bot pushed a commit to flutter/tests that referenced this pull request Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants