Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create package:devtools_app_shared #6210

Merged
merged 19 commits into from
Aug 18, 2023

Conversation

kenzieschmoll
Copy link
Member

Work towards #6208.

This is a refactor to pull code out from package:devtools_app that will be shared and used by both DevTools and DevTools extensions.

package:devtools_app_shared exports:

  • service_extensions.dart (exported separately so that the as extensions prefix can be used easily where this library is imported)
  • service.dart (service management libraries service_manager.dart, which the DevTools ServiceConnectionManager extends with any devtools-specific functionality that we shouldn't expose, connected_app.dart, isolate_manager.dart, service_extension_manager.dart, eval_on_dart_library.dart, etc.)
  • ui.dart (common UI elements like standard DevTools buttons, splitters, headers, dialogs, and theme)
  • utils.dart (globals framework, auto dispose, list utilities and other utils)

This package is under construction and the remaining work before publishing is tracked on #6208.

@polina-c
Copy link
Contributor

PACKAGES.md in the root that shows how packages depend on each other, will help to understand things faster.
Example: https://github.com/dart-lang/leak_tracker/blob/main/pkgs/leak_tracker/lib/DEPENDENCIES.md

@polina-c
Copy link
Contributor

polina-c commented Aug 17, 2023

IMG-0436

@kenzieschmoll kenzieschmoll merged commit d0db8ae into flutter:master Aug 18, 2023
15 checks passed
@kenzieschmoll kenzieschmoll deleted the devtools_shared_flutter branch August 18, 2023 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants