-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create package:devtools_app_shared
#6210
Merged
kenzieschmoll
merged 19 commits into
flutter:master
from
kenzieschmoll:devtools_shared_flutter
Aug 18, 2023
Merged
Create package:devtools_app_shared
#6210
kenzieschmoll
merged 19 commits into
flutter:master
from
kenzieschmoll:devtools_shared_flutter
Aug 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenzieschmoll
requested review from
bkonyi,
elliette,
polina-c,
CoderDake and
a team
as code owners
August 17, 2023 21:24
5 tasks
PACKAGES.md in the root that shows how packages depend on each other, will help to understand things faster. |
polina-c
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards #6208.
This is a refactor to pull code out from
package:devtools_app
that will be shared and used by both DevTools and DevTools extensions.package:devtools_app_shared
exports:service_extensions.dart
(exported separately so that theas extensions
prefix can be used easily where this library is imported)service.dart
(service management librariesservice_manager.dart
, which the DevTools ServiceConnectionManager extends with any devtools-specific functionality that we shouldn't expose,connected_app.dart
,isolate_manager.dart
,service_extension_manager.dart
,eval_on_dart_library.dart
, etc.)ui.dart
(common UI elements like standard DevTools buttons, splitters, headers, dialogs, and theme)utils.dart
(globals framework, auto dispose, list utilities and other utils)This package is under construction and the remaining work before publishing is tracked on #6208.