Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[deep link] Fix a runtime json type error in deep link tab #7386

Merged
merged 3 commits into from
Mar 19, 2024
Merged

[deep link] Fix a runtime json type error in deep link tab #7386

merged 3 commits into from
Mar 19, 2024

Conversation

hannah-hyj
Copy link
Member

@hannah-hyj hannah-hyj commented Mar 19, 2024 •
edited
Loading

the typeError appeared after --dart2js-optimization=O1 was added in #7335

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or there is a reason for not adding tests.

build.yaml badge

If you need help, consider asking for help on Discord.

@hannah-hyj hannah-hyj requested a review from a team as a code owner March 19, 2024 00:29
@hannah-hyj hannah-hyj requested review from bkonyi and removed request for a team March 19, 2024 00:29
@hannah-hyj hannah-hyj changed the title [deep link] Fix a runtime json type error for deep link [deep link] Fix a runtime json type error in deep link tab Mar 19, 2024
kenzieschmoll
kenzieschmoll reviewed Mar 19, 2024
View reviewed changes
packages/devtools_app/lib/src/shared/server/_deep_links_api.dart Outdated
@@ -14,7 +14,8 @@ Future<List<String>> requestAndroidBuildVariants(String path) async {
);
final resp = await request(uri.toString());
if (resp?.statusOk ?? false) {
return json.decode(resp!.body);
final jsonObject = jsonDecode(resp!.body) as List;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can be return (jsonDecode(resp!.body) as List).cast<String>();

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@hannah-hyj hannah-hyj merged commit c6c3371 into flutter:master Mar 19, 2024
23 checks passed
hannah-hyj added a commit to hannah-hyj/devtools that referenced this pull request Mar 20, 2024
@hannah-hyj
[deep link] Fix a runtime json type error in deep link tab (flutter#7386
d48b4a4 
)

* Update _deep_links_api.dart

* Update _deep_links_api.dart

* resolve comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenzieschmoll kenzieschmoll kenzieschmoll approved these changes

@bkonyi bkonyi Awaiting requested review from bkonyi bkonyi is a code owner automatically assigned from flutter/devtools-reviewers

Assignees
No one assigned
Labels
release-notes-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hannah-hyj @kenzieschmoll