Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to dtd 2.0.0 #7405

Merged
merged 5 commits into from
Mar 21, 2024
Merged

update to dtd 2.0.0 #7405

merged 5 commits into from
Mar 21, 2024

Conversation

CoderDake
Copy link
Contributor

@CoderDake CoderDake commented Mar 20, 2024


Updating to new DTD 2.0.0
I think DtdConnectionInfo and onDtdConnectionChange are still appropriate names, so I'm leaving those

@CoderDake CoderDake marked this pull request as ready for review March 20, 2024 21:51
@CoderDake CoderDake requested a review from a team as a code owner March 20, 2024 21:51
@CoderDake CoderDake requested review from bkonyi and removed request for a team March 20, 2024 21:51
@CoderDake CoderDake marked this pull request as draft March 20, 2024 21:52
@CoderDake CoderDake marked this pull request as ready for review March 20, 2024 21:54
Copy link
Member

@kenzieschmoll kenzieschmoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update all affected changelogs. If any changelog has an unreleased version of the package (you can verify on pub), you can add the entry there.

@@ -12,6 +12,7 @@ To learn more about DevTools, check out the

* Fixed an issue preventing DevTools from connecting to Flutter apps that are not
launched from Flutter Tools. - [#6848](https://github.com/flutter/devtools/issues/6848)
* Update `package:dtd` to `2.0.0` - [#7405](https://github.com/flutter/devtools/pull/7405)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to include this in the release notes. Release notes are for user facing changes that we want to announce.

Copy link
Member

@kenzieschmoll kenzieschmoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one comment but lgtm

@CoderDake CoderDake added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 21, 2024
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 21, 2024
Copy link

auto-submit bot commented Mar 21, 2024

auto label is removed for flutter/devtools/7405, due to - The status or check suite Verify PR Release Note Requirements has failed. Please fix the issues identified (or deflake) before re-applying this label.

@CoderDake CoderDake added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 21, 2024
Copy link

auto-submit bot commented Mar 21, 2024

auto label is removed for flutter/devtools/7405, due to - The status or check suite Verify PR Release Note Requirements has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 21, 2024
@CoderDake CoderDake merged commit df55d15 into flutter:master Mar 21, 2024
23 of 28 checks passed
@CoderDake CoderDake deleted the dtd2 branch March 21, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants