Refactor and cleanup byte utilities #7406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenzieschmoll
commented
Mar 20, 2024
| return prettyPrintBytes( | ||
| getValue(dataObject), | ||
| includeUnit: true, | ||
| kbFractionDigits: 0, |
There was a problem hiding this comment.
@polina-c should these columns actually have KB fraction digits of size 1? This PR changes the default value for this parameter so I added the 0 here to keep the current behavior, but wanted to check if this is the current behavior by accident or if it is intentional.
There was a problem hiding this comment.
agree that this should probably be changed to 1.
jacob314
reviewed
Mar 20, 2024
packages/devtools_app/lib/src/screens/network/network_request_inspector_views.dart
Outdated
Show resolved
Hide resolved
jacob314
reviewed
Mar 20, 2024
packages/devtools_app/lib/src/shared/primitives/byte_utils.dart
Outdated
Show resolved
Hide resolved
jacob314
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactor / cleanup is in preparation of an upcoming PR.