Fix integration_test/test/live_connection/eval_and_inspect_test.dart
flake
#8123
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards #8013
Tries to fix one of our top integration test flakes:
Evaluation is async since it requires a response from the VM service. I think this test was flaking because we were looking for the eval response in the console too soon. This PR adds and uses a test utility function (
retryUntilFound
) that will retry looking for afinder
with asafePumpDuration
in between until the found or there are no more retries.