[vm] Disable expensive timeline parameter in bytecode reader

Change-Id: Iddb9e5f7164a053116ad604d42c27c26be45aabb Reviewed-on: https://dart-review.googlesource.com/c/81900 Reviewed-by: Alexander Markov <[email protected]> Commit-Queue: Zach Anderson <[email protected]>
flutter · Oct 29, 2018 · 50a3460 · 50a3460
1 parent e414b58
commit 50a3460
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/runtime/vm/compiler/frontend/bytecode_reader.cc b/runtime/vm/compiler/frontend/bytecode_reader.cc
@@ -43,8 +43,12 @@ void BytecodeMetadataHelper::ReadMetadata(const Function& function) {
 #if !defined(PRODUCT)
   TimelineDurationScope tds(Thread::Current(), Timeline::GetCompilerStream(),
                             "BytecodeMetadataHelper::ReadMetadata");
+  // This increases bytecode reading time by ~7%, so only keep it around for
+  // debugging.
+#if defined(DEBUG)
   tds.SetNumArguments(1);
   tds.CopyArgument(0, "Function", function.ToQualifiedCString());
+#endif  // defined(DEBUG)
 #endif  // !defined(PRODUCT)
 
   const intptr_t node_offset = function.kernel_offset();