Skip to content

Commit

Permalink
move this define to be with its friends in flutter_defines.gni
Browse files Browse the repository at this point in the history
I'd like to get to the point where the only Flutter-specific
configuration is defines, in flutter_defines.gni.

Change-Id: Idda141c4dcdb5f18275e29d2ab60bb73bf416d59
Reviewed-on: https://skia-review.googlesource.com/c/169102
Auto-Submit: Mike Klein <[email protected]>
Reviewed-by: Brian Osman <[email protected]>
Commit-Queue: Mike Klein <[email protected]>
  • Loading branch information
Mike Klein authored and Skia Commit-Bot committed Nov 7, 2018
1 parent e5a06e7 commit 62cc5f5
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
3 changes: 0 additions & 3 deletions BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -130,9 +130,6 @@ config("skia_public") {
}
if (skia_enable_flutter_defines) {
defines += flutter_defines

# Flutter always wants this https://github.com/flutter/flutter/issues/11402
defines += [ "SK_ENABLE_DUMP_GPU" ]
}
if (!skia_enable_gpu) {
defines += [ "SK_SUPPORT_GPU=0" ]
Expand Down
3 changes: 3 additions & 0 deletions gn/flutter_defines.gni
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@ flutter_defines = [
"SK_DISABLE_EXPLICIT_GPU_RESOURCE_ALLOCATION",
"SK_LEGACY_SKCODEC_NONE_ENUM",

# Flutter always wants this https://github.com/flutter/flutter/issues/11402
"SK_ENABLE_DUMP_GPU",

# Remove software rasterizers to save some code size.
"SK_DISABLE_AAA",
"SK_DISABLE_DAA",
Expand Down

0 comments on commit 62cc5f5

Please sign in to comment.