Make CkPicture resurrectable

flutter · Dec 1, 2020 · 6315d7f · 6315d7f
1 parent b9a0b5e
commit 6315d7f
Show file tree

Hide file tree

Showing 18 changed files with 1,296 additions and 204 deletions.
diff --git a/lib/web_ui/dev/goldens_lock.yaml b/lib/web_ui/dev/goldens_lock.yaml
@@ -1,2 +1,2 @@
 repository: https://github.com/flutter/goldens.git
-revision: 06e0333b8371965dce5dc05e140e6dfb454f33fa
+revision: ac75f12c6e93461369e1391da6cc20bf8cb08829
diff --git a/lib/web_ui/dev/test_runner.dart b/lib/web_ui/dev/test_runner.dart
@@ -458,7 +458,11 @@ class TestCommand extends Command<bool> with ArgUtils {
           continue;
         }
 
-        if (path.split(testFilePath.relativeToWebUi).contains('golden_tests')) {
+        // All files under test/golden_tests are considered golden tests.
+        final bool isUnderGoldenTestsDirectory = path.split(testFilePath.relativeToWebUi).contains('golden_tests');
+        // Any file whose name ends with "_golden_test.dart" is run as a golden test.
+        final bool isGoldenTestFile = path.basename(testFilePath.relativeToWebUi).endsWith('_golden_test.dart');
+        if (isUnderGoldenTestsDirectory || isGoldenTestFile) {
           screenshotTestFiles.add(testFilePath);
         } else {
           unitTestFiles.add(testFilePath);