review comments followup

flutter · Oct 26, 2018 · 663c259 · 663c259
1 parent b3edacd
commit 663c259
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/flow/embedded_views.h b/flow/embedded_views.h
@@ -13,7 +13,7 @@ namespace flow {
 
 class EmbeddedViewParams {
  public:
-  SkPoint translatePixels;
+  SkPoint offsetPixels;
   SkSize sizePoints;
 };
 

diff --git a/flow/layers/platform_view_layer.cc b/flow/layers/platform_view_layer.cc
@@ -24,7 +24,7 @@ void PlatformViewLayer::Paint(PaintContext& context) const {
   }
   EmbeddedViewParams params;
   SkMatrix transform = context.canvas.getTotalMatrix();
-  params.translatePixels = SkPoint::Make(transform.getTranslateX(), transform.getTranslateY());
+  params.offsetPixels = SkPoint::Make(transform.getTranslateX(), transform.getTranslateY());
   params.sizePoints = size_;
 
   context.view_embedder->CompositeEmbeddedView(view_id_, params);

diff --git a/shell/platform/darwin/ios/framework/Source/FlutterPlatformViews.mm b/shell/platform/darwin/ios/framework/Source/FlutterPlatformViews.mm
@@ -94,9 +94,11 @@
 
 void FlutterPlatformViewsController::CompositeEmbeddedView(int view_id,
                                                            const flow::EmbeddedViewParams& params) {
+  // TODO(amirh): assert that this is running on the platform thread once we support the iOS
+  // embedded views thread configuration.
   CGFloat screenScale = [[UIScreen mainScreen] scale];
   CGRect rect =
-      CGRectMake(params.translatePixels.x() / screenScale, params.translatePixels.y() / screenScale,
+      CGRectMake(params.offsetPixels.x() / screenScale, params.offsetPixels.y() / screenScale,
                  params.sizePoints.width(), params.sizePoints.height());
 
   UIView* view = views_[view_id];