Skip to content

Commit

Permalink
[Impeller] Do not skip the GLES render pass if the command list is em…
Browse files Browse the repository at this point in the history
…pty (#50381)

The render pass may need to apply other changes such as painting the clear color.

See flutter/flutter#142639
  • Loading branch information
jason-simmons authored Feb 6, 2024
1 parent 67f1c2b commit 7c2f6c8
Showing 1 changed file with 0 additions and 7 deletions.
7 changes: 0 additions & 7 deletions impeller/renderer/backend/gles/render_pass_gles.cc
Original file line number Diff line number Diff line change
Expand Up @@ -151,10 +151,6 @@ struct RenderPassData {
const std::shared_ptr<GPUTracerGLES>& tracer) {
TRACE_EVENT0("impeller", "RenderPassGLES::EncodeCommandsInReactor");

if (commands.empty()) {
return true;
}

const auto& gl = reactor.GetProcTable();
#ifdef IMPELLER_DEBUG
tracer->MarkFrameStart(gl);
Expand Down Expand Up @@ -517,9 +513,6 @@ bool RenderPassGLES::OnEncodeCommands(const Context& context) const {
if (!IsValid()) {
return false;
}
if (commands_.empty()) {
return true;
}
const auto& render_target = GetRenderTarget();
if (!render_target.HasColorAttachment(0u)) {
return false;
Expand Down

0 comments on commit 7c2f6c8

Please sign in to comment.