Clarify file sharing flags in FML filesystem APIs on Windows

Use shared mode when requesting read access and exclusive mode for write access
flutter · Dec 9, 2022 · abb4f3a · abb4f3a
1 parent 030950f
commit abb4f3a
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/fml/platform/win/file_win.cc b/fml/platform/win/file_win.cc
@@ -85,11 +85,11 @@ static DWORD GetDesiredAccessFlags(FilePermission permission) {
 static DWORD GetShareFlags(FilePermission permission) {
   switch (permission) {
     case FilePermission::kRead:
-      return FILE_SHARE_READ;
+      return FILE_SHARE_READ | FILE_SHARE_WRITE | FILE_SHARE_DELETE;
     case FilePermission::kWrite:
-      return FILE_SHARE_WRITE;
+      return 0;
     case FilePermission::kReadWrite:
-      return FILE_SHARE_READ | FILE_SHARE_WRITE;
+      return 0;
   }
   return FILE_SHARE_READ;
 }