Make fml/status_or.h compatible with .clang_tidy. (#48002)

Work towards flutter/flutter#134969.
flutter · Nov 16, 2023 · f8698f8 · f8698f8
1 parent 27fe2c3
commit f8698f8
Showing 1 changed file with 15 additions and 4 deletions.
diff --git a/fml/status_or.h b/fml/status_or.h
@@ -31,7 +31,12 @@ namespace fml {
 template <typename T>
 class StatusOr {
  public:
+  // These constructors are intended be compatible with absl::status_or.
+  // NOLINTNEXTLINE(google-explicit-constructor)
   StatusOr(const T& value) : status_(), value_(value) {}
+
+  // These constructors are intended be compatible with absl::status_or.
+  // NOLINTNEXTLINE(google-explicit-constructor)
   StatusOr(const Status& status) : status_(status), value_() {}
 
   StatusOr(const StatusOr&) = default;
@@ -63,13 +68,19 @@ class StatusOr {
   bool ok() const { return status_.ok(); }
 
   const T& value() const {
-    FML_CHECK(status_.ok());
-    return value_.value();
+    if (status_.ok()) {
+      return value_.value();
+    }
+    FML_LOG(FATAL) << "StatusOr::value() called on error Status";
+    FML_UNREACHABLE();
   }
 
   T& value() {
-    FML_CHECK(status_.ok());
-    return value_.value();
+    if (status_.ok()) {
+      return value_.value();
+    }
+    FML_LOG(FATAL) << "StatusOr::value() called on error Status";
+    FML_UNREACHABLE();
   }
 
  private: