Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[embedder][glfw] Add support for locales to glfw shell #22657

Merged
merged 10 commits into from
Nov 24, 2020
Merged

[embedder][glfw] Add support for locales to glfw shell #22657

merged 10 commits into from
Nov 24, 2020

Commits on Nov 20, 2020

  1. Add support for locales to glfw shell 

    The other linux shell (and all the other embedding) have support for
getting the locales from the system and sending them over the
flutter/localization channel. The glfw shell does not have that which is
causing us to crash on an assert now that Locale is no longer nullable
in Platform.

This adds a similar approach to what is going on over in the other linux
shell to this one.

I haven't added tests or anything yet, just wanted to get this out there
to see if this is reasonable.
    @rokob
    rokob committed Nov 20, 2020
    Configuration menu
    Copy the full SHA
    efc980a View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2020

  1. Add tests for glfw locales

    @rokob
    rokob committed Nov 22, 2020
    Configuration menu
    Copy the full SHA
    d3c3dab View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2020

  1. Add tests for glfw locales

    @rokob
    rokob committed Nov 23, 2020
    Configuration menu
    Copy the full SHA
    85117d5 View commit details
    Browse the repository at this point in the history

  2. Fix licenses

    @rokob
    rokob committed Nov 23, 2020
    Configuration menu
    Copy the full SHA
    ebd9dbd View commit details
    Browse the repository at this point in the history

  3. Move locale parsing to a system_utils.h, reduce exposed functions and… 

    … use environment variables in the tests
    @rokob
    rokob committed Nov 23, 2020
    Configuration menu
    Copy the full SHA
    7fbf3ac View commit details
    Browse the repository at this point in the history

  4. Change public to only be the new header which is exposed for tests

    @rokob
    rokob committed Nov 23, 2020
    Configuration menu
    Copy the full SHA
    a4fc6db View commit details
    Browse the repository at this point in the history

  5. gn format

    @rokob
    rokob committed Nov 23, 2020
    Configuration menu
    Copy the full SHA
    656bfa6 View commit details
    Browse the repository at this point in the history

  6. use a regular enum instead of enum class to avoid noise static_cast

    @rokob
    rokob committed Nov 23, 2020
    Configuration menu
    Copy the full SHA
    2d0a87f View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2020

  1. Use maps to cleanup test environment variable setup/cleanup code

    @rokob
    rokob committed Nov 24, 2020
    Configuration menu
    Copy the full SHA
    d38ec35 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into glfw-locale

    @rokob
    rokob committed Nov 24, 2020
    Configuration menu
    Copy the full SHA
    280b5f5 View commit details
    Browse the repository at this point in the history