Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[web] Render PlatformViews with SLOT tags. #25747

Merged
merged 37 commits into from
May 21, 2021
Merged

[web] Render PlatformViews with SLOT tags. #25747

merged 37 commits into from
May 21, 2021

Commits on May 20, 2021

  1. Wrap all the contents of the glass-pane in a shadow root.

    @ditman
    ditman committed May 20, 2021
    Configuration menu
    Copy the full SHA
    6ea7e48 View commit details
    Browse the repository at this point in the history

  2. Make analyzer happy

    @ditman
    ditman committed May 20, 2021
    Configuration menu
    Copy the full SHA
    61ed861 View commit details
    Browse the repository at this point in the history

  3. Tweak semantics_test so it is shadow-DOM aware.

    @ditman
    ditman committed May 20, 2021
    Configuration menu
    Copy the full SHA
    5e1720d View commit details
    Browse the repository at this point in the history

  4. Render all text_editing primitives inside the new shadow root.

    @ditman
    ditman committed May 20, 2021
    Configuration menu
    Copy the full SHA
    7b76403 View commit details
    Browse the repository at this point in the history

  5. Tweak text_editing_test so it is shadow-DOM aware.

    @ditman
    ditman committed May 20, 2021
    Configuration menu
    Copy the full SHA
    0d11719 View commit details
    Browse the repository at this point in the history

  6. dartfmt -w .

    @ditman
    ditman committed May 20, 2021
    Configuration menu
    Copy the full SHA
    b5b4ec8 View commit details
    Browse the repository at this point in the history

  7. Do not select flt-glass-pane all the time. Reuse the reference inside .

    @ditman
    ditman committed May 20, 2021
    Configuration menu
    Copy the full SHA
    149debf View commit details
    Browse the repository at this point in the history

  8. Don't mess with the dart version in tests

    @ditman
    ditman committed May 20, 2021
    Configuration menu
    Copy the full SHA
    a1de790 View commit details
    Browse the repository at this point in the history

  9. Revert fanciness

    @ditman
    ditman committed May 20, 2021
    Configuration menu
    Copy the full SHA
    6daf5c6 View commit details
    Browse the repository at this point in the history

  10. Ensure the glass-pane and its shadow root exist before testing.

    @ditman
    ditman committed May 20, 2021
    Configuration menu
    Copy the full SHA
    e51ad1d View commit details
    Browse the repository at this point in the history

  11. Make dom_renderer_test shadow-root aware.

    @ditman
    ditman committed May 20, 2021
    Configuration menu
    Copy the full SHA
    bb97136 View commit details
    Browse the repository at this point in the history

  12. Do not use flt-glass-pane selectors across the code. Expose the shado… 

    …w root from domRenderer.
    @ditman
    ditman committed May 20, 2021
    Configuration menu
    Copy the full SHA
    1ade522 View commit details
    Browse the repository at this point in the history

  13. Make canvas_golden_test shadow-DOM aware.

    @ditman
    ditman committed May 20, 2021
    Configuration menu
    Copy the full SHA
    9e9820d View commit details
    Browse the repository at this point in the history

  14. Add a root Node parameter to text measurement, and pass the correct o… 

    …ne when the domRenderer is initializing.
    @ditman
    ditman committed May 20, 2021
    Configuration menu
    Copy the full SHA
    172fddc View commit details
    Browse the repository at this point in the history

  15. [wip] Platform views in slots!

    @ditman
    ditman committed May 20, 2021
    Configuration menu
    Copy the full SHA
    da4317e View commit details
    Browse the repository at this point in the history

  16. Remove flag to enable/disable feature. Cleanup unused code.

    @ditman
    ditman committed May 20, 2021
    Configuration menu
    Copy the full SHA
    6412db7 View commit details
    Browse the repository at this point in the history

  17. Ensure all positioning happens in the slot container. 

    Also:
* Do not modify the output of the render function passed by the user.
* Add a bunch of documentation
* Fix a couple of asserts in the content_manager that were asserting the
opposite that what they were supposed to (!!!)
    @ditman
    ditman committed May 20, 2021
    Configuration menu
    Copy the full SHA
    6a9258a View commit details
    Browse the repository at this point in the history

  18. Make content height:100% if it isn't set by the user. Warn the user.

    @ditman
    ditman committed May 20, 2021
    Configuration menu
    Copy the full SHA
    0d41b5c View commit details
    Browse the repository at this point in the history

  19. Prevent re-creating the same view multiple times in the CK renderer. … 

    …It messes with clip counts :)
    @ditman
    ditman committed May 20, 2021
    Configuration menu
    Copy the full SHA
    a57a5c3 View commit details
    Browse the repository at this point in the history

  20. Make flt-glass-pane tag name configurable.

    @ditman
    ditman committed May 20, 2021
    Configuration menu
    Copy the full SHA
    63370d5 View commit details
    Browse the repository at this point in the history

  21. Noop _compositeWithParams for disposed views, so all the disposed vie… 

    …ws in a frame can be reported later by submitFrame.
    @ditman
    ditman committed May 20, 2021
    Configuration menu
    Copy the full SHA
    bb68314 View commit details
    Browse the repository at this point in the history

  22. Adapt tests to look for PlatformViews in their new locations.

    @ditman
    ditman committed May 20, 2021
    Configuration menu
    Copy the full SHA
    1203eb3 View commit details
    Browse the repository at this point in the history

  23. Volkswagen the framework tests (replicate old behavior of returning a… 

    … non-functioning platform view when under testing)
    @ditman
    ditman committed May 20, 2021
    Configuration menu
    Copy the full SHA
    15bc192 View commit details
    Browse the repository at this point in the history

  24. Decouple rendering of platform view contents and slots lifecycle, sim… 

    …plifies stuff. See what breaks!
    @ditman
    ditman committed May 20, 2021
    Configuration menu
    Copy the full SHA
    8c5a13a View commit details
    Browse the repository at this point in the history

  25. Remove unused var.

    @ditman
    ditman committed May 20, 2021
    Configuration menu
    Copy the full SHA
    3c55ce8 View commit details
    Browse the repository at this point in the history

  26. Add unit tests for the new platform_views classes.

    @ditman
    ditman committed May 20, 2021
    Configuration menu
    Copy the full SHA
    38d3191 View commit details
    Browse the repository at this point in the history

  27. Appease analyzer

    @ditman
    ditman committed May 20, 2021
    Configuration menu
    Copy the full SHA
    6397962 View commit details
    Browse the repository at this point in the history

  28. Make semantics/text_field_test Shadow-DOM aware.

    @ditman
    ditman committed May 20, 2021
    Configuration menu
    Copy the full SHA
    314e246 View commit details
    Browse the repository at this point in the history

  29. Add licenses for new files.

    @ditman
    ditman committed May 20, 2021
    Configuration menu
    Copy the full SHA
    518b2e2 View commit details
    Browse the repository at this point in the history

  30. Address PR feedback.

    @ditman
    ditman committed May 20, 2021
    Configuration menu
    Copy the full SHA
    ea60e8c View commit details
    Browse the repository at this point in the history

  31. Fix embedded_views.dart imports.

    @ditman
    ditman committed May 20, 2021
    Configuration menu
    Copy the full SHA
    d060e90 View commit details
    Browse the repository at this point in the history

  32. Use Object? as the type for the ParameterizedPlatformViewFactory, ins… 

    …tead of Map<dynamic, dynamic>?.
    @ditman
    ditman committed May 20, 2021
    Configuration menu
    Copy the full SHA
    4bca48c View commit details
    Browse the repository at this point in the history

  33. Separate slot rendering from platform view content management. 

    Remove caching ability from Slots (only required for the canvaskit rendering, will be added there)
    @ditman
    ditman committed May 20, 2021
    Configuration menu
    Copy the full SHA
    3d819ca View commit details
    Browse the repository at this point in the history

  34. Add ViewClipChain class to encapsulate the clip root, the contents, a… 

    …nd the clipCount of views in the canvaskit backend.
    @ditman
    ditman committed May 20, 2021
    Configuration menu
    Copy the full SHA
    4959eea View commit details
    Browse the repository at this point in the history

  35. Fix semantics_test after rebase.

    @ditman
    ditman committed May 20, 2021
    Configuration menu
    Copy the full SHA
    8d0bac1 View commit details
    Browse the repository at this point in the history

  36. Ensure user supplied content is correctly sized.

    @ditman
    ditman committed May 20, 2021
    Configuration menu
    Copy the full SHA
    1697d17 View commit details
    Browse the repository at this point in the history

  37. Update Dartdoc so it is aware of the new createPlatformViewSlot funct… 

    …ion everywhere.
    @ditman
    ditman committed May 20, 2021
    Configuration menu
    Copy the full SHA
    f374b1f View commit details
    Browse the repository at this point in the history