Windows: Make task_runner_unittests.cc more deterministic.
#29500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluttergithubbot
force-pushed
the
master
branch
from
b1a8771
to
2962099
Compare
|
This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold. |
bdero
approved these changes
Jan 19, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 19, 2022
zanderso
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 19, 2022
* bdab647 Roll Skia from 9f231c330962 to 8276fa8ef102 (2 revisions) (flutter/engine#30912) * 7002447 Remove redundant `--template` arguments from code samples (flutter/engine#30909) * cef8bce [Web Text Input] ensure the input element is put in the DOM on desktop safari (flutter/engine#30885) * 31b1a1d cleanup #28013 (flutter/engine#29500)
clocksmith
pushed a commit
to clocksmith/flutter
that referenced
this pull request
Mar 8, 2022
* bdab647 Roll Skia from 9f231c330962 to 8276fa8ef102 (2 revisions) (flutter/engine#30912) * 7002447 Remove redundant `--template` arguments from code samples (flutter/engine#30909) * cef8bce [Web Text Input] ensure the input element is put in the DOM on desktop safari (flutter/engine#30885) * 31b1a1d cleanup flutter#28013 (flutter/engine#29500)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is cleanup #28013 from #29484 (comment).
This PR will enable
task_runner_unittests.ccto mockTaskTimePoint::clock::now()by overriding, and maketask_runner_unittests.ccmore deterministic.No tests in
flutter/tests.Pre-launch Checklist
writing and running engine tests.
///).