Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate RuntimeEnvironment#application to ApplicationProvider#getApplicationContext #32557

Conversation

utzcoz
Copy link
Contributor

@utzcoz utzcoz commented Apr 9, 2022

The RuntimeEnvironment#application is deprecated, and it's recommended to use ApplicationProvider#getApplicationContext to get application context for Robolectric tests. The ApplicationProvider#getApplicationContext also can help make test more compatible with AndroidX instrumentation tests.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@utzcoz
Copy link
Contributor Author

utzcoz commented Apr 9, 2022

Hi @zanderso , could you help review this PR? Thanks.

@chinmaygarde chinmaygarde added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Apr 14, 2022
@fluttergithubbot fluttergithubbot merged commit 3090e5c into flutter:main Apr 14, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 14, 2022
@utzcoz utzcoz deleted the migrate-to-ApplicationProvider-getApplicationContext branch April 15, 2022 00:21
justinmc pushed a commit to justinmc/engine that referenced this pull request Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform-android waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants