Some fixes for dart2wasm #38167
Some fixes for dart2wasm #38167
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
| @@ -176,9 +176,9 @@ class ColorSpace {} | |||
| @staticInterop | |||
| class SkWebGLContextOptions { | |||
| external factory SkWebGLContextOptions({ | |||
| required int antialias, | |||
| required double antialias, | |||
There was a problem hiding this comment.
This really shouldn't be necessary, but doesn't seem harmful. If I have a chance I'll try and get it working.
|
|
||
| /// Type-safe JS Promises | ||
| @JS('Promise') | ||
| @staticInterop | ||
| abstract class Promise<T> { | ||
| abstract class Promise<T extends Object?> { |
There was a problem hiding this comment.
Are any of these type parameters really adding value? It might make sense just to take Object values.
|
test-exempt: wasm compatibility |
eyebrowsoffire
added
autosubmit
…117031) * cda2be86e Some fixes for dart2wasm (flutter/engine#38167) * 14194c40e Roll Fuchsia Mac SDK from Cd_ZtrDVcpQ85HRL3... to FQQdl8AGAsALFniHl... (flutter/engine#38269)
* A few fixes to get things compiling via dart2wasm. * Use `futureToPromise`. * Some more fixes for dart2wasm. * Allow promises to have nullable objects.
* A few fixes to get things compiling via dart2wasm. * Use `futureToPromise`. * Some more fixes for dart2wasm. * Allow promises to have nullable objects.
…lutter#117031) * cda2be86e Some fixes for dart2wasm (flutter/engine#38167) * 14194c40e Roll Fuchsia Mac SDK from Cd_ZtrDVcpQ85HRL3... to FQQdl8AGAsALFniHl... (flutter/engine#38269)
No description provided.