-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Windows] Fix crash if the Dart entry point is null #38173
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaakovschectman
approved these changes
Dec 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
cbracken
approved these changes
Dec 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
loic-sharma
added
the
autosubmit
Merge PR when tree becomes green via auto submit App
label
Dec 12, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 12, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 12, 2022
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 12, 2022
…116920) * d72975724 Roll Skia from 0cb546781e89 to 833bfcb2b52f (1 revision) (flutter/engine#38218) * c7a95c510 Roll Dart SDK from 21f2997a8fc6 to 6334e84d6956 (4 revisions) (flutter/engine#38187) * d945c155c Roll Skia from 833bfcb2b52f to bb9378b61c4f (5 revisions) (flutter/engine#38221) * 8fe61bc32 Roll Dart SDK from 6334e84d6956 to f32c7b011906 (3 revisions) (flutter/engine#38223) * 2148fc003 [Windows] Fix headless mode crash (flutter/engine#38173)
loic-sharma
added a commit
to loic-sharma/flutter-engine
that referenced
this pull request
Dec 12, 2022
loic-sharma
added a commit
to loic-sharma/flutter-engine
that referenced
this pull request
Dec 16, 2022
itsjustkevin
pushed a commit
that referenced
this pull request
Dec 16, 2022
loic-sharma
added a commit
to loic-sharma/flutter-engine
that referenced
this pull request
Jan 3, 2023
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jan 19, 2023
…lutter#116920) * d72975724 Roll Skia from 0cb546781e89 to 833bfcb2b52f (1 revision) (flutter/engine#38218) * c7a95c510 Roll Dart SDK from 21f2997a8fc6 to 6334e84d6956 (4 revisions) (flutter/engine#38187) * d945c155c Roll Skia from 833bfcb2b52f to bb9378b61c4f (5 revisions) (flutter/engine#38221) * 8fe61bc32 Roll Dart SDK from 6334e84d6956 to f32c7b011906 (3 revisions) (flutter/engine#38223) * 2148fc003 [Windows] Fix headless mode crash (flutter/engine#38173)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Windows Flutter engine crashes if it is launched with a
nullptr
Dart entry point:This is needed for scenarios like headless mode with no views. Fixes flutter/flutter#116753
I'll prepare a cherry pick after this is merged.
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.