[Impeller Scene] Convert vertex positions to match Impeller's clip space orientation #38174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmaygarde
approved these changes
Dec 10, 2022
| std::function<void(Scalar* destination, | ||
| const void* source, | ||
| const ComponentProperties& component_props, | ||
| const AttributeProperties& attribute_props)>; | ||
| struct AttributeProperties { |
There was a problem hiding this comment.
Just noticed this, but, can we zero these out by default?
There was a problem hiding this comment.
Done. I forget to do this a lot, I wonder if there's a clang-format lint that can help.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 10, 2022
…'s clip space orientation (flutter/engine#38174)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 10, 2022
…'s clip space orientation (flutter/engine#38174)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 10, 2022
…'s clip space orientation (flutter/engine#38174)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 10, 2022
…'s clip space orientation (flutter/engine#38174)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 10, 2022
…'s clip space orientation (flutter/engine#38174)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 10, 2022
…'s clip space orientation (flutter/engine#38174)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 11, 2022
…'s clip space orientation (flutter/engine#38174)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 11, 2022
…116843) * 6b1c0c23f [Impeller Scene] Convert vertex positions to match Impeller's clip space orientation (flutter/engine#38174) * 41ec2804a Roll Fuchsia Linux SDK from rRJIjuO-dPNCpCTd9... to 8O5rMR_ehMaL3YhZ5... (flutter/engine#38177) * 3dfd13f1d Roll Skia from 1b194c67700e to 491f5c134f76 (2 revisions) (flutter/engine#38182) * 690f0e81c Fix sampler offsets (flutter/engine#38170) * f24f2cc0a Roll Skia from 491f5c134f76 to 0d482f9fa8b3 (1 revision) (flutter/engine#38183) * fbb79e704 [Impeller Scene] Refactor Nodes/Meshes for simplicity and GLTF compatibility (flutter/engine#38180)
loic-sharma
pushed a commit
to loic-sharma/flutter-engine
that referenced
this pull request
Dec 16, 2022
loic-sharma
pushed a commit
to loic-sharma/flutter-engine
that referenced
this pull request
Jan 3, 2023
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jan 19, 2023
…lutter#116843) * 6b1c0c23f [Impeller Scene] Convert vertex positions to match Impeller's clip space orientation (flutter/engine#38174) * 41ec2804a Roll Fuchsia Linux SDK from rRJIjuO-dPNCpCTd9... to 8O5rMR_ehMaL3YhZ5... (flutter/engine#38177) * 3dfd13f1d Roll Skia from 1b194c67700e to 491f5c134f76 (2 revisions) (flutter/engine#38182) * 690f0e81c Fix sampler offsets (flutter/engine#38170) * f24f2cc0a Roll Skia from 491f5c134f76 to 0d482f9fa8b3 (1 revision) (flutter/engine#38183) * fbb79e704 [Impeller Scene] Refactor Nodes/Meshes for simplicity and GLTF compatibility (flutter/engine#38180)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GLTF geometry follows a right-handed coordinate system where +z is model "front" and +y is model "top". Impeller has a left-handed clip space. Inverting Z is the simplest and most predictable conversion with respect to a default camera orientation such that model "right" is towards the right side of the viewport (+x in Impeller clip space) and model "top" is towards the top of the viewport (+y in Impeller clip space).
Also refactors the VerticesBuilder to support more specific behaviors (we'll need more AttributeWriter procs soon, like for tangents).
Before:
After:
