[fuchsia] Make it easy to flip the whole system between flutter_jit_a… #3873
Conversation
|
That was fast :) So this does 1) and 2) from the list in the email thread, yes? And 3) would presumably be a follow on change? |
|
Right. As for 3), I'm open to name suggestions for a GN variable :) |
| @@ -4,7 +4,7 @@ | |||
|
|
|||
| import("//flutter/build/flutter_app.gni") | |||
|
|
|||
| flutter_app("hello_flutter") { | |||
| flutter_jit_app("hello_flutter") { | |||
There was a problem hiding this comment.
Does this need to change? I thought most clients would use flutter_app and follow external configuration?
There was a problem hiding this comment.
I think the idea here is to build the hello_flutter app both ways to make sure that both ways work.
There was a problem hiding this comment.
The intent is to ensure there's at least one app built both ways. There's a flutter_aot_app just below here.
build/flutter_app.gni
Outdated
| # disable_analysis (optional) | ||
| # Prevents the analysis script from being generated. | ||
| template("flutter_app") { | ||
| if (true) { |
There was a problem hiding this comment.
I'm not sure I like the idea of this being toggled by a global flag, but I think it's good to be explicit that there's a choice here.
| # disable_analysis (optional) | ||
| # Prevents the analysis script from being generated. | ||
| template("flutter_app") { | ||
| template("flutter_jit_app") { |
There was a problem hiding this comment.
Maybe "flutter_dynamic_app" or "dynamic_flutter_app"
There was a problem hiding this comment.
And "flutter_static_app" or "static_flutter_app" below.
…pp and flutter_aot_app.
…pp and flutter_aot_app.