Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fuchsia] Replace deprecated AddLocalChild #38788

Merged

Commits on Jan 11, 2023

  1. [fuchsia] Replace deprecated AddLocalChild

    `AddLocalChild(LocalComponent*)` is deprecated.
    
    It was replaced by:
    
    `AddLocalChild(LocalComponentFactory)`, which is a type alias for a
    lambda that returns a `std::unique_ptr<LocalComponentImpl>`.
    
    This change addresses problems that arised due to object lifetime
    management of the components, and allows RealmBuilder to model the
    component lifecycle of local components in a way that's more consistent
    with other components.
    
    The RealmBuilder-built `Realm` now owns the lifetime of the local
    components, instead of the client, and those objects are valid until
    the `Realm` is destroyed.
    
    Bug: fxbug.dev/109804
    richkadel committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    eb5fb82 View commit details
    Browse the repository at this point in the history