-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Vulkan embedder example #39052
Fix Vulkan embedder example #39052
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
f2a5602
to
6359825
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a fine fix. Can you address the CLA so we can make progress?
Also, per @zanderso, we should figure out how to run these examples on CI. But it may require us to get CMake and related tools on the bots.
I have? cla/google has green checkmark for me. |
Hmm, not sure why the bot didn't update. Check check mark in the presubs is green though. All good. |
…119347) * 63aaca1a6 Roll Fuchsia Mac SDK from MyL3JcOBni9CTx9wz... to 11wOrGFBXTHgxQVOi... (flutter/engine#39192) * a2a3a13e9 Roll Skia from 091ec9bdcf9b to 0b75650caf2a (5 revisions) (flutter/engine#39190) * 189a69d99 Fix Vulkan embedder example (flutter/engine#39052)
Fix a just outright syntax error in CMakeLists of vulkan_glfw and specify a missing include for std::chrono stuff.
Fixes: flutter/flutter#118957
Pre-launch Checklist
///
).