Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Vulkan embedder example #39052

Merged
merged 1 commit into from
Jan 27, 2023
Merged

Conversation

nanokatze
Copy link
Contributor

@nanokatze nanokatze commented Jan 21, 2023

Fix a just outright syntax error in CMakeLists of vulkan_glfw and specify a missing include for std::chrono stuff.

Fixes: flutter/flutter#118957

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@google-cla
Copy link

google-cla bot commented Jan 21, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Member

@chinmaygarde chinmaygarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a fine fix. Can you address the CLA so we can make progress?

Also, per @zanderso, we should figure out how to run these examples on CI. But it may require us to get CMake and related tools on the bots.

@nanokatze
Copy link
Contributor Author

This seems like a fine fix. Can you address the CLA so we can make progress?

I have? cla/google has green checkmark for me.

@chinmaygarde
Copy link
Member

Hmm, not sure why the bot didn't update. Check check mark in the presubs is green though. All good.

@chinmaygarde chinmaygarde added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 27, 2023
@auto-submit auto-submit bot merged commit 189a69d into flutter:main Jan 27, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 27, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jan 27, 2023
…119347)

* 63aaca1a6 Roll Fuchsia Mac SDK from MyL3JcOBni9CTx9wz... to 11wOrGFBXTHgxQVOi... (flutter/engine#39192)

* a2a3a13e9 Roll Skia from 091ec9bdcf9b to 0b75650caf2a (5 revisions) (flutter/engine#39190)

* 189a69d99 Fix Vulkan embedder example (flutter/engine#39052)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App needs tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vulkan GLFW example is broken
3 participants