Make fml/... compatible with .clang_tidy.
#47992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie or stuartmorgan on the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
matanlurey
added
the
autosubmit
bdero
added
the
revert
auto-submit
bot
removed
the
revert
auto-submit bot
pushed a commit
that referenced
this pull request
Nov 14, 2023
This reverts commit 3cd830c.
auto-submit bot
added a commit
that referenced
this pull request
Nov 14, 2023
Reverts #47992 Initiated by: bdero This change reverts the following previous change: Original Description: Work towards flutter/flutter#134969. All changes were made automatically (i.e. with `--fix`).
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 14, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 14, 2023
…138382) flutter/engine@77b952f...74a9de4 2023-11-14 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Make `fml/...` compatible with `.clang_tidy`." (flutter/engine#48004) 2023-11-13 [email protected] Make `fml/...` compatible with `.clang_tidy`. (flutter/engine#47992) 2023-11-13 [email protected] Roll Skia from 9ac5cad143ec to c5aef650e2b2 (3 revisions) (flutter/engine#47991) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
|
test-exempt: helps unblock turning on a check that will automatically enforce the change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards flutter/flutter#134969.
All changes were made automatically (i.e. with
--fix).