Commits on Nov 15, 2023

1. [macOS] Clean up allocations in menu plugin test …

   Runs all FlutterMenuPlugin tests in an AutoReleasepoolTest, which
   ensures all allocations are cleaned up.
   
   Also extracts out some hackery into the FlutterMenuPluginTest fixture to
   ensure that NSApplication instantiates everything necessary to do menu
   bar manipulation.
   
   Also replaces the use of OCMock in FlutterMenuPluginTest.mm with a fake
   FakePluginRegistrar class. This avoids unnecessary use of OCMock in the
   tests, which has been responsible for flakiness in some tests, in
   particular where the mock is used across threads. This test was not
   problematic, but the fake makes the tests more readable.
   
   Also fixes linter warnings about using NSLocalizedString for user-facing
   strings.
   
   Issue: flutter/flutter#104789
   Issue: flutter/flutter#127441
   Issue: flutter/flutter#124840

   

   cbracken committed Nov 15, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for 53cb871
   • Browse repository at this point

   Copy the full SHA

   53cb871 View commit details

   Browse the repository at this point in the history