Add support for exposing accessibility identifier as accessibilityIdentifier on iOS #48858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 11, 2023
This PR adds `String? identifier` to `Semantics` and `SemanticsProperties`. The `identifier` will be exposed on Android as `resource-id` and on iOS as `accessibilityIdentifier`. Mainly targeted at #17988 Initial Engine PR with Android support: flutter/engine#47961 iOS Engine PR: flutter/engine#48858 ### Migration This change breaks the SemanticsUpdateBuilder API which is on the Framework<-->Engine border. For more details see [engine PR](flutter/engine#47961). Steps: part 1: [engine] add `SemanticsUpdateBuilderNew` flutter/engine#47961 **part 2: [flutter] use `SemanticsUpdateBuilderNew`** <-- we are here part 3: [engine] update `SemanticsUpdateBuilder` to be the same as `SemanticsUpdateBuilderNew`* part 4: [flutter] use (now updated) `SemanticsUpdateBuilder` again. part 5: [engine] remove `SemanticsBuilderNew`
bartekpacia
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 11, 2023
…ibilityIdentifier on iOS (flutter/engine#48858)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 12, 2023
…ibilityIdentifier on iOS (flutter/engine#48858)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 12, 2023
…139948) flutter/engine@d001419...ea1a306 2023-12-11 [email protected] Roll Skia from bd5941d727be to 461256aac224 (1 revision) (flutter/engine#48897) 2023-12-11 [email protected] Move `third_party/yapf` to `flutter/third_party/yapf`. (flutter/engine#48847) 2023-12-11 [email protected] Roll Skia from 17bd70326a49 to bd5941d727be (1 revision) (flutter/engine#48896) 2023-12-11 [email protected] SemanticsUpdateBuilder migration: introduce `identifier` (flutter/engine#48882) 2023-12-11 [email protected] Add support for exposing accessibility identifier as accessibilityIdentifier on iOS (flutter/engine#48858) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a sibling of #47961 but for iOS
Pre-launch Checklist
///).