Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reland "Android testing use min sdk 19" #49086

Closed
wants to merge 2 commits into from

Conversation

utzcoz
Copy link
Contributor

@utzcoz utzcoz commented Dec 15, 2023

The latest Robolectric version, 4.11.x, removed the support for SDKs < 19 by following AndroidX strategy. Also following flutter/buildroot#750, and removing obsolete SDK checking in code to pass android_lint checking after bumping minSdk to 19 for testing target.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

@utzcoz
Copy link
Contributor Author

utzcoz commented Dec 15, 2023

I will learn how to integrate engine with flutter to ensure it doesn't break the flutter/flutter#138262 again.

@utzcoz utzcoz force-pushed the Android-testing-use-minSdk-19 branch from 8fcf6a1 to ec1270a Compare December 15, 2023 14:38
@dnfield
Copy link
Contributor

dnfield commented Feb 28, 2024

Are you interested in bumping this further to api 21? We've recently moved that up as the minimum elsewhere

@dnfield
Copy link
Contributor

dnfield commented Feb 28, 2024

I'm going to close this since it's not passing tests right now and it never left draft status. Feel free to re-open if you plan to work on it again - or I might just do this to bump things to 21.

@dnfield dnfield closed this Feb 28, 2024
@utzcoz
Copy link
Contributor Author

utzcoz commented Feb 28, 2024

@dnfield Sorry for late response. I did't move this PR going because I didn't have enough time to test engine code with Flutter main repository's test code as the origin PR passed with Engine CI but failed with Flutter main repository's CI after checked-in. I can update this PR to bump related things to SDK 21 this weekend. I will reopen this PR and mark it as draft state.

@utzcoz
Copy link
Contributor Author

utzcoz commented Feb 28, 2024

Oh, looks like I don't have a permission to reopen it. I will resent one after updating.

@dnfield
Copy link
Contributor

dnfield commented Mar 1, 2024

I ended up landing something like this for API 21 in #51032 (which had to get reverted because of one last framework test and then relanded). Thanks though!

@utzcoz
Copy link
Contributor Author

utzcoz commented Mar 4, 2024

Sorry, I will delay it to next weekend. @dnfield If you want to lan similar things, you can do it based on your pace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants