Android Platform Views support Verified Input Events #49268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@text-exemption-reviewers" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
johnmccutchan
force-pushed
the
verified_input_events
branch
from
babac33
to
f6ba24f
Compare
johnmccutchan
force-pushed
the
verified_input_events
branch
2 times, most recently
from
3bb27d5
to
663b7ce
Compare
|
test-exempt: Test will be checked into the flutter repository. |
johnmccutchan
force-pushed
the
verified_input_events
branch
from
663b7ce
to
ad80399
Compare
camsim99
approved these changes
Jan 2, 2024
shell/platform/android/io/flutter/embedding/android/MotionEventTracker.java
Outdated
Show resolved
Hide resolved
| // We are in virtual display mode or don't have a reference to the original MotionEvent. | ||
| // In this case we manually recreate a MotionEvent to be delivered. This MotionEvent | ||
| // will fail the verifiable input check. | ||
|
|
There was a problem hiding this comment.
What are the cases are where we don't have the original event if virtual display isn't being used (if we know them)? And why won't we have it when virtual display is used? Do these cases warrant warning users here?
There was a problem hiding this comment.
IIUC, the only case where this will happen (when not using virtual display) is when a gesture detector runs and creates new events related to the detected gesture.
1. MotionEvent is captured and delivered to PlatformViewWrapper.onTouchEvent (TLHC) or FlutterMutatorView.onTouchEvent (HC) 2. MotionEvent is transformed by the AndroidTouchProcessor into a PointerEvent 3. AndroidTouchProcessor sends the PointerEvent over the PlatformViewChannel 4. Framework processes the PointerEvent 5. Framework sends the PointerEvent over the PlatformViewChannel. 6. in PlatformViewsController.onTouch a new MotionEvent is synthesized 7. The MotionEvent is delivered to the platform view After step (6) the MotionEvent will fail Verification (android.hardware.input.InputManager.verifyInputEvent). The fix requires that in step (6) we use the original motion event delivered in step (1) instead of synthesizing a new instance.
johnmccutchan
force-pushed
the
verified_input_events
branch
from
ad80399
to
b2de306
Compare
johnmccutchan
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 2, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 2, 2024
…140824) flutter/engine@9d89f87...b02d59a 2024-01-02 [email protected] Android Platform Views support Verified Input Events (flutter/engine#49268) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
johnmccutchan
added a commit
to flutter/flutter
that referenced
this pull request
Jan 2, 2024
This is an integration test associated with flutter/engine#49268
auto-submit bot
added a commit
to flutter/flutter
that referenced
this pull request
Jan 2, 2024
Reverts #140806 Initiated by: zanderso This change reverts the following previous change: Original Description: This is an integration test associated with flutter/engine#49268
This was referenced May 2, 2024
auto-submit bot
pushed a commit
that referenced
this pull request
May 14, 2024
Fixes flutter/flutter#146570, which tracks a regression from #49268 regarding platform view inputs in some specific cases. This PR translates the input event location to be the same as the location we calculated before #49268, returning to the previous behavior, while maintaining the input event's verified status (I checked this manually with the `InputManager`). Tested manually with the reproduction in the linked issue. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
flutteractionsbot
pushed a commit
to flutteractionsbot/engine
that referenced
this pull request
May 22, 2024
Fixes flutter/flutter#146570, which tracks a regression from flutter#49268 regarding platform view inputs in some specific cases. This PR translates the input event location to be the same as the location we calculated before flutter#49268, returning to the previous behavior, while maintaining the input event's verified status (I checked this manually with the `InputManager`). Tested manually with the reproduction in the linked issue. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Android Platform Views process MotionEvents in a complicated way:
After step (6) the MotionEvent will fail Verification (
android.hardware.input.InputManager.verifyInputEvent).The fix requires that in step (6) we use the original motion event delivered in step (1) instead of synthesizing a new instance.