Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Roll dart to 7764e6962e22afcf4b58c4e3cef3147330f3c884. #4960

Merged
merged 5 commits into from
Apr 10, 2018
Merged

Roll dart to 7764e6962e22afcf4b58c4e3cef3147330f3c884. #4960

merged 5 commits into from
Apr 10, 2018

Conversation

aam
Copy link
Member

@aam aam commented Apr 10, 2018

Changes since last roll:

7764e6962e Initial API to build analysis contexts (replaces ContextLocator.locateContexts)
5ea271bb01 Clean up documentation of implicit new/const insertions tests.
cf93009caf Removed the magic const feature from implicit-creation.md
bd39320b3b Recover from error on undefined continue label.
5d89a1ac32 Add tests for mixin application constructor forwarding.
e6962790a1 Use import URIs when invalidating files
23c59bd819 Fix compare_failures
290cc58e71 Use actual receiver when error-wrapping a null-aware property get.
34763bc4c9 Reland "[VM] Introduction of type testing stubs - Part 1-4"
a86b864fa9 Handle updated .packages in incremental compiler
f555ae505a Trust type annotations in strong mode
0a4a3bed68 When cloning YieldStatement, copy the flags
91bbc798fa Skip abstract forwarding stubs
7689dc9e06 Bring in the latest pub_semver
f71d204185 Fix expected type in substByContext
5e99872770 Improve missing/invalid type reference recovery
899dbe4dae Forward type arguments in one-shot interceptors.
1fd3011f47 dart2js: Add more whole-program information to dump-info
5e23c2843d Revert "[infra] Temporarily disable Windows SDK builder on CQ"
2471888d4a Serialize any MethodInvocation as possible const.
b430570364 dart2js: handle constant casts with type variable substitutions
3575b810b3 Only add const in a constant context (issue 32819)
09f7d2aee5 dart2js: naive support for instantiations in constants - ignore the actual instantiation
4dd5e6e6ad js_runtime: fix _JsonMap keys list type
71ffe976a9 Correctly handle constant fields when computing constness (take 2)
d58b0e2d44 [VM] Mark bigint test slow after small Smi change
1e997ee6b7 Revert "Reland "[VM] Introduction of type testing stubs - Part 1-4""
00097adce0 Remove reference to deprecated setter
cb065a116f [infra] Update checked-in SDK version to 2.0.0-dev.46.0
0e9a77a360 [VM] Reduce Smi size to 32 bit on 64 bit platforms
34bfefd508 [gardening] Update status file
969c0de335 Avoid crash on EOF error in file with Windows line encoding
8054409a02 Reland "[VM] Introduction of type testing stubs - Part 1-4"

@aam
Roll dart to 7764e69.
555e324 
Changes since last roll:

```
7764e69 Initial API to build analysis contexts (replaces ContextLocator.locateContexts)
5ea271b Clean up documentation of implicit new/const insertions tests.
cf93009 Removed the magic const feature from implicit-creation.md
bd39320 Recover from error on undefined continue label.
5d89a1a Add tests for mixin application constructor forwarding.
e696279 Use import URIs when invalidating files
23c59bd Fix compare_failures
290cc58 Use actual receiver when error-wrapping a null-aware property get.
34763bc Reland "[VM] Introduction of type testing stubs - Part 1-4"
a86b864 Handle updated .packages in incremental compiler
f555ae5 Trust type annotations in strong mode
0a4a3be When cloning YieldStatement, copy the flags
91bbc79 Skip abstract forwarding stubs
7689dc9 Bring in the latest pub_semver
f71d204 Fix expected type in substByContext
5e99872 Improve missing/invalid type reference recovery
899dbe4 Forward type arguments in one-shot interceptors.
1fd3011 dart2js: Add more whole-program information to dump-info
5e23c28 Revert "[infra] Temporarily disable Windows SDK builder on CQ"
2471888 Serialize any MethodInvocation as possible const.
b430570 dart2js: handle constant casts with type variable substitutions
3575b81 Only add const in a constant context (issue 32819)
09f7d2a dart2js: naive support for instantiations in constants - ignore the actual instantiation
4dd5e6e js_runtime: fix _JsonMap keys list type
71ffe97 Correctly handle constant fields when computing constness (take 2)
d58b0e2 [VM] Mark bigint test slow after small Smi change
1e997ee Revert "Reland "[VM] Introduction of type testing stubs - Part 1-4""
00097ad Remove reference to deprecated setter
cb065a1 [infra] Update checked-in SDK version to 2.0.0-dev.46.0
0e9a77a [VM] Reduce Smi size to 32 bit on 64 bit platforms
34bfefd [gardening] Update status file
969c0de Avoid crash on EOF error in file with Windows line encoding
8054409 Reland "[VM] Introduction of type testing stubs - Part 1-4"
```
@aam
Copy link
Member Author

aam commented Apr 10, 2018

cc @Hixie for license script change - ignore skia/third_party/freetype2 (similarly to how we ignore skia/third_party/freetype), that was introduced in skia roll.

@rmistry rmistry mentioned this pull request Apr 10, 2018
Merged
@aam aam requested review from a-siva and alexmarkov April 10, 2018 21:04
alexmarkov
alexmarkov approved these changes Apr 10, 2018
View reviewed changes
Copy link
Contributor

@alexmarkov alexmarkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aam aam merged commit 31c5bb4 into flutter:master Apr 10, 2018
@aam aam deleted the roll-dart-20180410 branch April 10, 2018 21:09
@Hixie
Copy link
Contributor

Hixie commented Apr 10, 2018

@jason-simmons Is it still accurate to say that we use our own version and that we are not linking these freetype libraries into the engine binary?

@jason-simmons
Copy link
Member

Yes - we're using:
https://github.com/flutter/engine/blob/master/DEPS#L357

@rmistry rmistry mentioned this pull request Apr 10, 2018
Closed
@chinmaygarde chinmaygarde mentioned this pull request Apr 10, 2018
Merged
aam added a commit to aam/engine that referenced this pull request Apr 10, 2018
@aam
Revert "Roll dart to 7764e69. (flutter#4960)"
dccedb8 
This reverts commit 31c5bb4 as it
breaks ios_debug_arm build https://build.chromium.org/p/client.flutter/builders/Mac%20Engine/builds/2573/steps/build%20ios_debug_arm/logs/stdio
aam added a commit that referenced this pull request Apr 10, 2018
@aam
Revert "Roll dart to 7764e69. (#4960)" (#4965)
8cd2727 
This reverts commit 31c5bb4 as it
breaks ios_debug_arm build https://build.chromium.org/p/client.flutter/builders/Mac%20Engine/builds/2573/steps/build%20ios_debug_arm/logs/stdio
@Hixie
Copy link
Contributor

Hixie commented Apr 10, 2018

Excellent, thanks.

@aam aam mentioned this pull request Apr 10, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexmarkov alexmarkov alexmarkov approved these changes

@a-siva a-siva Awaiting requested review from a-siva

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aam @Hixie @jason-simmons @alexmarkov @googlebot