Add a comment explaining the lifecycle of tls_command_pool_map.
#50623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jonah Williams <[email protected]>
Co-authored-by: Jonah Williams <[email protected]>
matanlurey
added
the
autosubmit
gaaclarke
reviewed
Feb 14, 2024
Co-authored-by: gaaclarke <[email protected]>
sealesj
pushed a commit
to sealesj/engine
that referenced
this pull request
Feb 15, 2024
…utter#50623) Partial work towards flutter/flutter#142083. Still investigating a fix.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 16, 2024
jason-simmons
added a commit
to jason-simmons/flutter
that referenced
this pull request
Feb 16, 2024
2024-02-15 [email protected] [Android] Minor refactor: Remove redundant methods. (flutter/engine#50647) 2024-02-15 [email protected] [Impeller] consolidate transforms in PositionUVWriter (flutter/engine#50635) 2024-02-15 [email protected] [web] Add dynamic view sizing (v2) (flutter/engine#50271) 2024-02-14 [email protected] Add useful default options to scenario_app/bin/android_integration_tests.dart (flutter/engine#50667) 2024-02-14 [email protected] Fix github md "Note" and "Tip" blocks in Android shell README (flutter/engine#50664) 2024-02-14 [email protected] [Fuchsia] Run run_with_dart_aot test on fuchsia_profile_x64 (flutter/engine#50613) 2024-02-14 [email protected] Make all Android scenario_app activities full-screen, even on older Android versions. (flutter/engine#50666) 2024-02-14 [email protected] Roll Skia from eae42ea9f7bc to 2d5cf67614d0 (6 revisions) (flutter/engine#50660) 2024-02-14 [email protected] Add a comment explaining the lifecycle of tls_command_pool_map. (flutter/engine#50623) 2024-02-14 [email protected] [web] Increase tolerance for golden diffs on Safari (flutter/engine#50655)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 16, 2024
2024-02-15 [email protected] [Android] Minor refactor: Remove redundant methods. (flutter/engine#50647) 2024-02-15 [email protected] [Impeller] consolidate transforms in PositionUVWriter (flutter/engine#50635) 2024-02-15 [email protected] [web] Add dynamic view sizing (v2) (flutter/engine#50271) 2024-02-14 [email protected] Add useful default options to scenario_app/bin/android_integration_tests.dart (flutter/engine#50667) 2024-02-14 [email protected] Fix github md "Note" and "Tip" blocks in Android shell README (flutter/engine#50664) 2024-02-14 [email protected] [Fuchsia] Run run_with_dart_aot test on fuchsia_profile_x64 (flutter/engine#50613) 2024-02-14 [email protected] Make all Android scenario_app activities full-screen, even on older Android versions. (flutter/engine#50666) 2024-02-14 [email protected] Roll Skia from eae42ea9f7bc to 2d5cf67614d0 (6 revisions) (flutter/engine#50660) 2024-02-14 [email protected] Add a comment explaining the lifecycle of tls_command_pool_map. (flutter/engine#50623) 2024-02-14 [email protected] [web] Increase tolerance for golden diffs on Safari (flutter/engine#50655)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial work towards flutter/flutter#142083.
Still investigating a fix.