Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fuchsia] Run arm64 tests on terminal.qemu-arm64 on x64 hosts #50657

Merged
merged 14 commits into from
Feb 15, 2024
Merged

[Fuchsia] Run arm64 tests on terminal.qemu-arm64 on x64 hosts #50657

merged 14 commits into from
Feb 15, 2024
+29 −14

Conversation

zijiehe-google-com
Copy link
Contributor

@zijiehe-google-com zijiehe-google-com commented Feb 14, 2024 •
edited
Loading

This change replicas https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20Fuchsia%20arm64%20FEMU and runs tests on simulated arm64 on x64. E.g. https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20Engine%20Drone/1994921/overview
or more accurately, https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8756061244290412945/+/u/test:_arm64_emulator_based_debug_tests/stdout

The vulkan tests are excluded, qemu does not support vulkan.
The display_list_render_tests is excluded as it's way too slow (over 400 seconds).

After this change, comparing to femu_test.py, the only missing case is the dart-aot-runner-integration-test which is executed in fuchsia_profile_x64 anyway. It needs --no-lto in fuchsia_profile_arm64. I may need to confirm if the fuchsia_profile_arm64 build is used in fuchsia or the fuchsia_release_arm64.

Bug: flutter/flutter#140179

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@zijiehe-google-com zijiehe-google-com mentioned this pull request Feb 14, 2024
Merged
8 tasks
auto-submit bot pushed a commit that referenced this pull request Feb 14, 2024
@zijiehe-google-com
[Fuchsia] Run run_with_dart_aot test on fuchsia_profile_x64 (#50613)
c55e8b7 
This change starts running dart aot tests on fuchsia_profile_x64 builder which were previously ignored. But it also requires to build `profile` with `--no-lto`.
Since running tests are in general quite fast, this change does not exclude other test suites from fuchsia_profile_x64.

After this change, linux_fuchsia has higher coverage than the femu_test, later one can be removed.
But I may prefer submitting #50657 first, so we can fully remove the femu_test.py.

Bug: flutter/flutter#140179

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
@zijiehe-google-com zijiehe-google-com changed the title terminal.qemu-arm64 [Fuchsia] Run arm64 tests on terminal.qemu-arm64 on x64 hosts Feb 15, 2024
@zijiehe-google-com zijiehe-google-com marked this pull request as ready for review February 15, 2024 03:32
@flutter-dashboard
Copy link

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

Changes reported for pull request #50657 at sha 8c445b1

sealesj pushed a commit to sealesj/engine that referenced this pull request Feb 15, 2024
@zijiehe-google-com @sealesj
[Fuchsia] Run run_with_dart_aot test on fuchsia_profile_x64 (flutter#…
8bbea4c 
…50613)

This change starts running dart aot tests on fuchsia_profile_x64 builder which were previously ignored. But it also requires to build `profile` with `--no-lto`.
Since running tests are in general quite fast, this change does not exclude other test suites from fuchsia_profile_x64.

After this change, linux_fuchsia has higher coverage than the femu_test, later one can be removed.
But I may prefer submitting flutter#50657 first, so we can fully remove the femu_test.py.

Bug: flutter/flutter#140179

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
@zijiehe-google-com zijiehe-google-com added autosubmit Merge PR when tree becomes green via auto submit App and removed will affect goldens labels Feb 15, 2024
@zijiehe-google-com
Copy link
Contributor Author

Remove "will affect goldens" label, I do not think this change would impact golden set.

@auto-submit auto-submit bot merged commit aa3f016 into flutter:main Feb 15, 2024
31 checks passed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 16, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 16, 2024
@engine-flutter-autoroll
aa3f0167a [Fuchsia] Run arm64 tests on terminal.qemu-arm64 on x64 hos…
5faeeb3 
…ts (flutter/engine#50657)
jason-simmons added a commit to jason-simmons/flutter that referenced this pull request Feb 16, 2024
@jason-simmons
Manual roll Flutter Engine from b7103bc8b374 to 7de84271eb65
8c884f7 
2024-02-15 [email protected] Roll Skia from a8e4db1afac5 to 078b316e0563 (4 revisions) (flutter/engine#50700)
2024-02-15 [email protected] Roll Dart SDK from 5e442dc80903 to 9bbac4d40725 (2 revisions) (flutter/engine#50699)
2024-02-15 [email protected] [Android] Remove the unnecessary parent interface. (flutter/engine#50677)
2024-02-15 [email protected] [Impeller] Add an error message when failing to write golden screenshot. (flutter/engine#50698)
2024-02-15 [email protected] Roll Skia from 6ee2b5f61ae5 to a8e4db1afac5 (5 revisions) (flutter/engine#50696)
2024-02-15 [email protected] [Fuchsia] Run arm64 tests on terminal.qemu-arm64 on x64 hosts (flutter/engine#50657)
2024-02-15 [email protected] [Impeller] Updated benchmarks (flutter/engine#50694)
2024-02-15 [email protected] Documentation for test timeouts. (flutter/engine#50687)
2024-02-15 [email protected] Shift some Linux builders from Goma to RBE (flutter/engine#50653)
2024-02-15 [email protected] Roll Skia from 12d0b7fac4c3 to 6ee2b5f61ae5 (1 revision) (flutter/engine#50691)
@jason-simmons jason-simmons mentioned this pull request Feb 16, 2024
Merged
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Feb 16, 2024
@jason-simmons
Manual roll Flutter Engine from b7103bc8b374 to 7de84271eb65 (#143564)
6f6950b 
2024-02-15 [email protected] Roll Skia from a8e4db1afac5 to 078b316e0563 (4 revisions) (flutter/engine#50700)
2024-02-15 [email protected] Roll Dart SDK from 5e442dc80903 to 9bbac4d40725 (2 revisions) (flutter/engine#50699)
2024-02-15 [email protected] [Android] Remove the unnecessary parent interface. (flutter/engine#50677)
2024-02-15 [email protected] [Impeller] Add an error message when failing to write golden screenshot. (flutter/engine#50698)
2024-02-15 [email protected] Roll Skia from 6ee2b5f61ae5 to a8e4db1afac5 (5 revisions) (flutter/engine#50696)
2024-02-15 [email protected] [Fuchsia] Run arm64 tests on terminal.qemu-arm64 on x64 hosts (flutter/engine#50657) 2024-02-15 [email protected] [Impeller] Updated benchmarks (flutter/engine#50694)
2024-02-15 [email protected] Documentation for test timeouts. (flutter/engine#50687)
2024-02-15 [email protected] Shift some Linux builders from Goma to RBE (flutter/engine#50653)
2024-02-15 [email protected] Roll Skia from 12d0b7fac4c3 to 6ee2b5f61ae5 (1 revision) (flutter/engine#50691)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 16, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 16, 2024
@engine-flutter-autoroll
aa3f0167a [Fuchsia] Run arm64 tests on terminal.qemu-arm64 on x64 hos…
08adb05 
…ts (flutter/engine#50657)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Feb 16, 2024
@engine-flutter-autoroll
Roll Flutter Engine from b7103bc8b374 to dd530f1556df (17 revisions) (#…
6ee7e24 
…143565)

flutter/engine@b7103bc...dd530f1

2024-02-16 [email protected] Roll Dart SDK from 9bbac4d40725 to 947c8c487e28 (1 revision) (flutter/engine#50709)
2024-02-16 [email protected] Roll Skia from 3cbb5d6a71fe to c89a4cd72308 (2 revisions) (flutter/engine#50708)
2024-02-16 [email protected] [Windows] Improve `FlutterWindow` unit tests (flutter/engine#50676)
2024-02-16 [email protected] [et] Adds a logger (flutter/engine#50693)
2024-02-15 [email protected] Update README.md (flutter/engine#50702)
2024-02-15 [email protected] Roll Skia from 078b316e0563 to 3cbb5d6a71fe (2 revisions) (flutter/engine#50704)
2024-02-15 [email protected] Move the accesibility placeholder to the platform dispatcher. (flutter/engine#50608)
2024-02-15 [email protected] Roll Skia from a8e4db1afac5 to 078b316e0563 (4 revisions) (flutter/engine#50700)
2024-02-15 [email protected] Roll Dart SDK from 5e442dc80903 to 9bbac4d40725 (2 revisions) (flutter/engine#50699)
2024-02-15 [email protected] [Android] Remove the unnecessary parent interface. (flutter/engine#50677)
2024-02-15 [email protected] [Impeller] Add an error message when failing to write golden screenshot. (flutter/engine#50698)
2024-02-15 [email protected] Roll Skia from 6ee2b5f61ae5 to a8e4db1afac5 (5 revisions) (flutter/engine#50696)
2024-02-15 [email protected] [Fuchsia] Run arm64 tests on terminal.qemu-arm64 on x64 hosts (flutter/engine#50657)
2024-02-15 [email protected] [Impeller] Updated benchmarks (flutter/engine#50694)
2024-02-15 [email protected] Documentation for test timeouts. (flutter/engine#50687)
2024-02-15 [email protected] Shift some Linux builders from Goma to RBE (flutter/engine#50653)
2024-02-15 [email protected] Roll Skia from 12d0b7fac4c3 to 6ee2b5f61ae5 (1 revision) (flutter/engine#50691)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaseyHillers CaseyHillers CaseyHillers approved these changes

@jrwang jrwang jrwang approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zijiehe-google-com @jrwang @CaseyHillers