[canvaskit] Fix backdrop filter with platform views as children #51442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdebbar
approved these changes
Mar 15, 2024
yjbanov
approved these changes
Mar 15, 2024
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 15, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 15, 2024
…145226) flutter/engine@d107f65...c2fd533 2024-03-15 [email protected] [canvaskit] Fix backdrop filter with platform views as children (flutter/engine#51442) 2024-03-15 [email protected] Roll Skia from 54ecc23acf31 to 11b1a958c2ac (1 revision) (flutter/engine#51440) 2024-03-15 [email protected] [DisplayList] Pre-Compute saveLayer bounds in DLBuilder (flutter/engine#50935) 2024-03-15 [email protected] Roll Fuchsia Linux SDK from da-siZ7wPDA0Z0wXJ... to nTth7xxzAfENAJjMH... (flutter/engine#51446) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from da-siZ7wPDA0 to nTth7xxzAfEN If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug in CanvasKit where a backdrop filter with a platform view as a child will cause the backdrop filter to apply multiple times. This change fixes it by only applying the backdrop filter once.
The bug case is more likely to happen since #47317 landed because when we encounter an invisible platform view, we always create a new SkPicture instead of continuing to use the same SkPicture.
BEFORE:
AFTER:
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.