Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete Settings::msaa_samples. #52780

Merged
merged 3 commits into from
May 13, 2024
Merged

Delete Settings::msaa_samples. #52780

merged 3 commits into from
May 13, 2024

Conversation

chinmaygarde
Copy link
Member

Copy link
Member

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chinmaygarde chinmaygarde added the autosubmit Merge PR when tree becomes green via auto submit App label May 13, 2024
@auto-submit auto-submit bot merged commit a1cdcb6 into flutter:main May 13, 2024
33 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 14, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request May 14, 2024
…148276)

flutter/engine@13a561c...a1cdcb6

2024-05-13 [email protected] Delete Settings::msaa_samples. (flutter/engine#52780)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@chinmaygarde chinmaygarde deleted the no_msaa branch May 14, 2024 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App platform-android platform-ios
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete configuration of Settings::msaa_samples.
2 participants