Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flutter_releases] beta 3.23 release engine - actually delete impeller tests #53178

Conversation

christopherfujino
Copy link
Member

This is a follow up to #53163, where I deleted the ninja target to build the golden tests, however I forgot to delete the commands to actually run the tests. In post-submit, the tests ran again and failed: https://ci.chromium.org/ui/p/dart-internal/builders/flutter/Mac%20Production%20Engine%20Drone/12733/infra

This PR actually deletes the scripts to run the tests.

@flutter-dashboard
Copy link

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

@christopherfujino
Copy link
Member Author

@gaaclarke please double check my work here

"--variant",
"ci/host_release",
"--type",
"dart,dart-host,engine"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That name seems incorrect, it's a copy paste bug since impeller golden is listed in the name, but isn't listed in the --type argument.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh, good catch, these seem like tests we want to run :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gaaclarke restored this diff, PTAL

Copy link
Member

@gaaclarke gaaclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@christopherfujino christopherfujino added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 3, 2024
Copy link
Contributor

auto-submit bot commented Jun 3, 2024

auto label is removed for flutter/engine/53178, due to - The status or check suite Linux linux_android_aot_engine has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 3, 2024
@christopherfujino
Copy link
Member Author

Looks like network flake on linux_android_aot_engine:

* What went wrong:
Execution failed for task ':app:compileDebugKotlin'.
> Error while evaluating property 'filteredArgumentsMap' of task ':app:compileDebugKotlin'.
   > Could not resolve all files for configuration ':app:debugCompileClasspath'.
      > Failed to transform annotation-1.2.0.jar (androidx.annotation:annotation:1.2.0) to match attributes {artifactType=android-classes-jar, org.gradle.category=library, org.gradle.dependency.bundling=external, org.gradle.jvm.version=7, org.gradle.libraryelements=jar, org.gradle.status=release, org.gradle.usage=java-api}.
         > Could not download annotation-1.2.0.jar (androidx.annotation:annotation:1.2.0)
            > Could not get resource 'https://dl.google.com/dl/android/maven2/androidx/annotation/annotation/1.2.0/annotation-1.2.0.jar'.
               > Could not GET 'https://dl.google.com/dl/android/maven2/androidx/annotation/annotation/1.2.0/annotation-1.2.0.jar'.
                  > The server may not support the client's requested TLS protocol versions: (TLSv1.2, TLSv1.3). You may need to configure the client to allow other protocols to be used. For more on this, please refer to https://docs.gradle.org/8.3/userguide/build_environment.html#sec:gradle_system_properties in the Gradle documentation.
                     > Remote host terminated the handshake

Triggering re-run

@christopherfujino christopherfujino added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 3, 2024
@auto-submit auto-submit bot merged commit 2488e8b into flutter:flutter-3.23-candidate.0 Jun 3, 2024
27 checks passed
@christopherfujino christopherfujino deleted the cherrypicks-flutter-3.23-candidate.0 branch June 3, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants