Reland "[ios][platform_view] Use CAShapeLayer as the mask to avoid software rendering #53072" #53256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hellohuanlin
force-pushed
the
pv_mask_view_use_cashapelayer_backing_again
branch
from
094f05b
to
7fc9c31
Compare
hellohuanlin
commented
Jun 6, 2024
| [self setNeedsDisplay]; | ||
| } | ||
|
|
||
| - (void)dealloc { | ||
| CGPathRelease(pathSoFar_); |
There was a problem hiding this comment.
removing [super dealloc] is the only change.
chinmaygarde
approved these changes
Jun 6, 2024
|
@hellohuanlin can you update the description and explain what it's relanding, and what is changed from the original one that was reverted? |
jmagman
approved these changes
Jun 6, 2024
Done! |
hellohuanlin
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 7, 2024
…o avoid software rendering flutter#53072" (flutter/engine#53256)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 7, 2024
…149867) flutter/engine@fea8e51...5d5e0ee 2024-06-06 [email protected] Roll Skia from c1aae20f1c82 to a42ff08f2b2e (1 revision) (flutter/engine#53263) 2024-06-06 [email protected] Reland "[ios][platform_view] Use CAShapeLayer as the mask to avoid software rendering #53072" (flutter/engine#53256) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous PR was reverted because it was on top of an outdated commit prior to ARC. This PR rebases the main. The only change is removing the
[super dealloc]call that caused the compiler error.List which issues are fixed by this PR. You must list at least one issue.
Fixes flutter/flutter#142813
Fixes flutter/flutter#142830
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.